[pkg-fso-maint] [Fwd: Re: install.sh: tasks functions

[Luca Capello]

Hi Brian!

On Tue, 16 Jun 2009 12:56:39 +0200, Luca Capello wrote:
> On Tue, 16 Jun 2009 10:23:42 +0200, Steffen Moeller wrote:
>> +		case "$f" in
>> +			"partition")
>> +				if [ -n "$intern_no_partitioning" ]; then
>> +					echo " * Skipping partitioning since --no-partitioning flag set"
>> +					continue
>> +				fi

This does not work as expected, i.e. it does not partition even when it
is asked for.  I restored the previous (and correct) behavior with:

--8<---------------cut here---------------start------------->8---
-					continue
+				else
+					action_partition
--8<---------------cut here---------------end--------------->8---

>> +			"tasks")
>> +				if [ -z "$TASKS" ]; then
>> +					echo " * Skipping over installing tasks since none were specified"
>> +					continue

The same as for "partition" above applies here, with moreover the fact
that the if statement was not closed:

--8<---------------cut here---------------start------------->8---
-					continue
+				else
+					action_tasks
+				fi
--8<---------------cut here---------------end--------------->8---

> It seems OK for me and I have applied it to my local Git repository:
> once I have tested it, I will push it.

Tested, for the three cases, and applied:

  http://git.debian.org/?p=pkg-fso/files.git;a=commitdiff;h=6ee3c6e0e5e4255a729983817f5a193b102b41a0

Thx, bye,
Gismo / Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 314 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20090617/18add74b/attachment.pgp>