[pkg-fso-maint] [debian] phoneuid-messgaes crashes

Sebastian Reichel elektranox at gmail.com
Sun Feb 21 18:13:37 UTC 2010


On Sun, Feb 21, 2010 at 03:36:11AM +0100, arne anka wrote:
> >>I have absolutly no clue what may cause this crash and you did not
> >>include the python traceback.
> 
> well, after a reboot today, frameworkd died again and this time i
> tracked it down.
> as usual, the root cause is insufficient handling of non-ascii, this
> time in
> 
> subsystems/opimd/type_manager.py
> 
> at line 67
> 
> def make_comp_value(self, field_type, field_value, from_query = False):
>     if field_type=='phonenumber':
>         if from_query:
>             return re.escape(normalize_number(field_value)) # +'$'
>         else:
>             return normalize_number(field_value)
>     else:
> -            return str(field_value)
> +        try:
> +            return str(field_value)
> +        except:
> +            return unicode(field_value)

Thanks for tracing it :) I tried a bit with the interactive python
shell and I think it's enough to always return unicode(field_value)
- without the exception handling. I just uploaded an updated package
to pkg-fso containing this fix.

P.S.: I CC'd smartphones-userland, so that it can be fixed upstream.

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20100221/9ded1653/attachment.pgp>


More information about the pkg-fso-maint mailing list