[pkg-fso-maint] [RFR] templates://libphone-utils/{libphone-utils0.templates}

Christian PERRIER bubulle at debian.org
Sun Jan 3 09:06:26 UTC 2010


Please find, for review, the debconf templates and packages descriptions for the libphone-utils source package.

This review will last from Sunday, January 03, 2010 to Wednesday, January 13, 2010.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- libphone-utils.old/debian/libphone-utils0.templates	2009-12-29 13:39:26.555742884 +0100
+++ libphone-utils/debian/libphone-utils0.templates	2010-01-03 09:57:55.435993336 +0100
@@ -1,29 +1,29 @@
 Template: libphone-utils/international_prefix
 Type: string
 Default: 00
-_Description: international phone prefix:
- You can setup the prefix for international calls here.
- This prefix is "00" in a lot of countries.
+_Description: International phone prefix:
+ Please enter the prefix to dial for international calls.
+ This prefix is "00" in most countries.

Proper capitalization of synopsis.

Standard formulation for the long description. Avoid "here" as,
depending on the interface, "here" might vary....

s/a lot of/most for personal taste.

 
 Template: libphone-utils/national_prefix
 Type: string
 Default: 0
-_Description: national phone prefix:
- You can setup the prefix for national calls here.
- This prefix is "0" in a lot of countries.
+_Description: National phone prefix:
+ Please enter the prefix to dial for national calls.
+ This prefix is "0" in most countries.

Similar changes than above

 
 Template: libphone-utils/country_code
 Type: string
-Default: 49
-_Description: country code:
- You can setup your country code here.
- For example it is "49" for Germany.
+_Defaultchoice: 49
+_Description: Telephone country code:
+ Please enter the international telephone code for the local country
+ (for instance, "49" for Germany).

Similar changes than above. Add "Telephone" as "country code" might
refer to another kind of code (some users might enter the ISO code
even though the long description makes it clear this is the telephone
code).

_DefaultChoice allows translators to put their country's code as
default. That default will be used only with the said translation.

 
 Template: libphone-utils/area_code
 Type: string
 Default: 0
-_Description: area code:
- You can setup your area code here.
- For example it is "30" for Berlin.
- This is normally only needed with
- landline phones.
+_Description: Area code:
+ Please enter the telephone code for the local area (for instance,
+ "30" for Berlin in Germany).
+ .
+ This is normally only needed with landline phones.

Split in two paragraphs for clarity.

Not sure whether we should use DefaultChoice there. There are  few
reasons for this.

phone-utils.old/debian/control	2009-12-29 13:39:26.555742884 +0100
+++ libphone-utils/debian/control	2010-01-03 09:58:59.388992826 +0100
@@ -26,13 +26,13 @@
 Depends: libphone-utils0 (= ${binary:Version}),
          ${shlibs:Depends},
          ${misc:Depends}
-Description: library for basic phone operations (debug symbols)
+Description: library for basic phone operations - debug symbols

Use the defacto standard  "general description  - specific
description" which we promote in our review.

  This library contains basic functions needed by SHR
  phone software and FSO opimd daemon.
  .
  The library is used for handling international numbers.
  .
- This library contains the debug symbols for the library.
+ This package provides the debug symbols for the library.

Also one of our standard formulations.
 
 Package: libphone-utils-dev
 Section: libdevel
@@ -41,10 +41,10 @@
          ${shlibs:Depends},
          ${misc:Depends},
          libglib2.0-dev
-Description: library for basic phone operations (devel files)
+Description: library for basic phone operations - development files
  This library contains basic functions needed by SHR
  phone software and FSO opimd daemon.
  .
  The library is used for handling international numbers.
  .
- This package contains the development files for this library.
+ This package provides the development files for this library.

Similar changes.

-- 


-------------- next part --------------
Template: libphone-utils/international_prefix
Type: string
Default: 00
_Description: International phone prefix:
 Please enter the prefix to dial for international calls.
 This prefix is "00" in most countries.

Template: libphone-utils/national_prefix
Type: string
Default: 0
_Description: National phone prefix:
 Please enter the prefix to dial for national calls.
 This prefix is "0" in most countries.

Template: libphone-utils/country_code
Type: string
_Defaultchoice: 49
_Description: Telephone country code:
 Please enter the international telephone code for the local country
 (for instance, "49" for Germany).

Template: libphone-utils/area_code
Type: string
Default: 0
_Description: Area code:
 Please enter the telephone code for the local area (for instance,
 "30" for Berlin in Germany).
 .
 This is normally only needed with landline phones.
-------------- next part --------------
--- libphone-utils.old/debian/libphone-utils0.templates	2009-12-29 13:39:26.555742884 +0100
+++ libphone-utils/debian/libphone-utils0.templates	2010-01-03 09:57:55.435993336 +0100
@@ -1,29 +1,29 @@
 Template: libphone-utils/international_prefix
 Type: string
 Default: 00
-_Description: international phone prefix:
- You can setup the prefix for international calls here.
- This prefix is "00" in a lot of countries.
+_Description: International phone prefix:
+ Please enter the prefix to dial for international calls.
+ This prefix is "00" in most countries.
 
 Template: libphone-utils/national_prefix
 Type: string
 Default: 0
-_Description: national phone prefix:
- You can setup the prefix for national calls here.
- This prefix is "0" in a lot of countries.
+_Description: National phone prefix:
+ Please enter the prefix to dial for national calls.
+ This prefix is "0" in most countries.
 
 Template: libphone-utils/country_code
 Type: string
-Default: 49
-_Description: country code:
- You can setup your country code here.
- For example it is "49" for Germany.
+_Defaultchoice: 49
+_Description: Telephone country code:
+ Please enter the international telephone code for the local country
+ (for instance, "49" for Germany).
 
 Template: libphone-utils/area_code
 Type: string
 Default: 0
-_Description: area code:
- You can setup your area code here.
- For example it is "30" for Berlin.
- This is normally only needed with
- landline phones.
+_Description: Area code:
+ Please enter the telephone code for the local area (for instance,
+ "30" for Berlin in Germany).
+ .
+ This is normally only needed with landline phones.
--- libphone-utils.old/debian/control	2009-12-29 13:39:26.555742884 +0100
+++ libphone-utils/debian/control	2010-01-03 09:58:59.388992826 +0100
@@ -26,13 +26,13 @@
 Depends: libphone-utils0 (= ${binary:Version}),
          ${shlibs:Depends},
          ${misc:Depends}
-Description: library for basic phone operations (debug symbols)
+Description: library for basic phone operations - debug symbols
  This library contains basic functions needed by SHR
  phone software and FSO opimd daemon.
  .
  The library is used for handling international numbers.
  .
- This library contains the debug symbols for the library.
+ This package provides the debug symbols for the library.
 
 Package: libphone-utils-dev
 Section: libdevel
@@ -41,10 +41,10 @@
          ${shlibs:Depends},
          ${misc:Depends},
          libglib2.0-dev
-Description: library for basic phone operations (devel files)
+Description: library for basic phone operations - development files
  This library contains basic functions needed by SHR
  phone software and FSO opimd daemon.
  .
  The library is used for handling international numbers.
  .
- This package contains the development files for this library.
+ This package provides the development files for this library.
-------------- next part --------------
Source: libphone-utils
Section: libs
Priority: extra
Maintainer: Debian freesmartphone.org Team <pkg-fso-maint at lists.alioth.debian.org>
Uploaders: Sebastian Reichel <elektranox at gmail.com>
Build-Depends: cdbs,
               debhelper (>= 7),
               libglib2.0-dev,
               po-debconf
Standards-Version: 3.8.3
Homepage: http://shr-project.org

Package: libphone-utils0
Architecture: any
Depends: ${shlibs:Depends},
         ${misc:Depends}
Description: library for basic phone operations
 This library contains basic functions needed by SHR
 phone software and FSO opimd daemon.
 .
 The library is used for handling international numbers.

Package: libphone-utils0-dbg
Section: debug
Architecture: any
Depends: libphone-utils0 (= ${binary:Version}),
         ${shlibs:Depends},
         ${misc:Depends}
Description: library for basic phone operations - debug symbols
 This library contains basic functions needed by SHR
 phone software and FSO opimd daemon.
 .
 The library is used for handling international numbers.
 .
 This package provides the debug symbols for the library.

Package: libphone-utils-dev
Section: libdevel
Architecture: any
Depends: libphone-utils0 (= ${binary:Version}),
         ${shlibs:Depends},
         ${misc:Depends},
         libglib2.0-dev
Description: library for basic phone operations - development files
 This library contains basic functions needed by SHR
 phone software and FSO opimd daemon.
 .
 The library is used for handling international numbers.
 .
 This package provides the development files for this library.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20100103/fbdf5804/attachment.pgp>


More information about the pkg-fso-maint mailing list