[pkg-fso-maint] install.sh - please change the shebang to #!/bin/bash

[Jonas Smedegaard]

On Thu, Jan 21, 2010 at 04:41:42PM +0100, Steffen Möller wrote:
>Jonas Smedegaard wrote:
>> On Thu, Jan 21, 2010 at 01:19:49AM +0100, Gilles Filippini wrote:
>>> Hi,
>>>
>>> "read -t" is a bashism which triggers an error when /bin/sh is a link to
>>> dash, as in qtmoko v16.
>>>
>>> Please change the shebang to force using bash.
>>
>> Or better (if possible - I haven't read the actual code) patch the
>> script to not use bashisms - as that will require less memory and be
>> slightly faster, even when using /bin/sh symlinked to bash.
>
>If I had had a spontaneous idea then I would have done that. However, I
>did not even do a "man read". install.sh should be merged with the
>Debian Installer and not exist by itself, and with most time spent in
>cdebootstrap I did not care about optimising the rest. The time saved is
>most certainly less than what I would have invested for the test run.

Uh oh, it is just an install-time script.  sorry - just ignore my 
comment: I blindly assumed it was a runtime script.


  - Jonas

-- 
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20100121/cc658a11/attachment.pgp>