[pkg-fso-maint] Bug#638601: nodm: FTBFS with ld --as-needed

[Ilya Barygin]

Package: nodm
Version: 0.11-1
Severity: normal
Tags: upstream patch
User: debian-gcc at lists.debian.org
Usertags: ld-as-needed

The package fails to build when --as-needed linker option is enabled,
because of incorrect order of parameters passed to ld. Here's the bug
report in Ubuntu:
https://bugs.launchpad.net/ubuntu/+source/nodm/+bug/771123

See also
http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries

The following patch was used in Ubuntu to fix the problem.

only in patch2:
unchanged:
--- nodm-0.10.orig/Makefile.am
+++ nodm-0.10/Makefile.am
@@ -12,7 +12,7 @@
 testlibsources = $(libsources) test.c
 
 AM_CPPFLAGS = $(X11_CFLAGS)
-AM_LDFLAGS = $(PAM_LIBS) $(X11_LIBS)
+LIBS = $(PAM_LIBS) $(X11_LIBS)
 
 nodm_SOURCES = $(libsources) nodm.c
 nodm_CFLAGS = -DNODM_SESSION='"$(sbindir)/nodm"'
only in patch2:
unchanged:
--- nodm-0.10.orig/Makefile.in
+++ nodm-0.10/Makefile.in
@@ -226,7 +226,7 @@
 libsources = common.c log.c vt.c xsession-child.c xserver.c xsession.c dm.c
 testlibsources = $(libsources) test.c
 AM_CPPFLAGS = $(X11_CFLAGS)
-AM_LDFLAGS = $(PAM_LIBS) $(X11_LIBS)
+LIBS = $(PAM_LIBS) $(X11_LIBS)
 nodm_SOURCES = $(libsources) nodm.c
 nodm_CFLAGS = -DNODM_SESSION='"$(sbindir)/nodm"'
 man_MANS = nodm.8


-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric
  APT policy: (500, 'oneiric')
Architecture: i386 (i686)

Kernel: Linux 2.6.38-11-generic (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash