[pkg-fso-maint] Need a quick review of vala-terminal changes in git (was: Processed: tagging 650232, tagging 629795)

[Sebastian Reichel]

Hi Philipp,

On Wed, Dec 14, 2011 at 09:39:49PM +0100, Philipp Kaluza wrote:
> With all the excitement around the gta-04 I think it makes sense to keep
> this package alive a bit longer. :-)

It may also become useful on N900 :)

> As the vala language (and compiler) has evolved quite a bit since the
> 0.8 days, fixing this was more than a simple patch, so as noted above I
> poked Michael Lauer to release the fixes already slumbering in upstream
> git as vala-terminal 1.3 (thanks again), and packaged everything up.
> As this turned out a bit more intrusive than I'm comfortable with for an
> NMU, I'm asking you guys/gals for a review now. The changes are in the
> debian branch¹.
> 
> The package builds nicely using valac-0.12 and valac-0.14, but I bumped
> the Build-Depends to just "valac" (0.14 in unstable) simply to keep the
> generated .c files close to upstream. Oh, and I regenrate the .c files
> now, in case anybody later decides to patch the .vala files manually.

You forgot to patch away the generated files from the release.
Otherwise you have local changes.

> Add to that a migration to 3.0 (quilt) necessitated by the .bz2 tarball,
> and that's about it.

ok.

> Also, if you guys feel this work is worthwile, I'm happy to keep half an
> eye on this package, so feel free to add me as Uploader and set DMUA: yes.

Thanks. I added you to uploaders and added DMUA.

> I'm mainly need a quick review, if you have time please do the upload
> also, otherwise I'll poke my sponsor on your OK.

Upload done. It's not very time consuming compared to reviewing :P

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20111214/3afe4db7/attachment-0001.pgp>