[pkg-fso-maint] RFS: androidsdk-tools 22+git20130416~f55ffbb-1 (new)

["Steffen Möller"]

> Gesendet: Samstag, 17. August 2013 um 19:12 Uhr
> Von: "Steffen Möller" <steffen_moeller at gmx.de>
...
> 
> @Jakub, everyone is slightly afraid since the package is rather big and
> it is all a bit a step to the side from our routines. My suggestion is to
> link up with pkg-java as a start, where I presume most of pkg-fso are also
> contributors. This way we can share the reviewing in a easier way, you
> get immediate feedback through the subversion commits about who has some
> interest in your package, and there is quite a large number of DDs for it.

I was talking nonsense - you already gave a pointer to the package in pkg-java.
So, here about my first impressions - it is a nice package, and surprisingly small,
all debs below 1MB.

You use the perl package for pod2man, for which I have added that to the
build-depends. This is technically not required since build-essential covers
it, but since among all the java bits this is slighly unexpected, I thought
it should be mentioned.

The cdbs package is needed for all platforms to interpret debian/rules for all
the packages that you create - platform independent or not, so this goes to
regular build-depends. But since you have everything else only for platform-
independent packages, it should be fine to have those as build-depend-indep.
I admit not to oversee all the consequences this may have for the cdbs internal
rules and your common-post-build-indep:: target.

Since unfamiliar with the SDK, I would very much have liked to see more of
a description for the packages in debian/control.

Otherwise it seems fine. Please think about my comments above for a minute
and give some feedback. If I do not hear from you, I would later tonight feel
like uploading to experimental as a start.

Many greetings

Steffen

--- a/debian/control
+++ b/debian/control
@@ -4,9 +4,10 @@ Priority: extra
 Maintainer: Debian Java Maintainers <pkg-java-maintainers at lists.alioth.debian.org>
 Uploaders: Stefan Handschuh <handschuh.stefan at googlemail.com>,
  Jakub Adam <jakub.adam at ktknet.cz>
-Build-Depends: debhelper (>=9), javahelper, default-jdk, cdbs, bnd, libswt-gtk-3-java,
+Build-Depends: debhelper (>=9), cdbs
+Build-Depends-Indep: javahelper, default-jdk, bnd, libswt-gtk-3-java,
  libjfreechart-swt-java, eclipse-rcp (>= 3.8.1), libguava-java (>= 13.0.1),
- libkxml2-java
+ libkxml2-java, perl
 Standards-Version: 3.9.4
 Homepage: http://developer.android.com/tools/help/index.html
 Vcs-Git: git://anonscm.debian.org/git/pkg-java/androidsdk-tools.git