[pkg-fso-maint] Bug#860463: nodm: Missing handling of plymouth (#782456)

[Simon McVittie]

On Mon, 17 Apr 2017 at 12:05:41 +0200, Niels Thykier wrote:
> I have reviewed the nodm systemd service file plus the init.d script
> and I cannot see that it takes plymouth into account (which leads to
> #782456).  To the best of my knowledge, #782456 have to be fixed in
> the DMs.

I tried preparing an NMU to address this. I did this as an NMU because
I was added to the Uploaders by the nodm maintainers during the last
upload, but I don't feel particularly responsible for this package,
and I have no commit access to the pkg-fso git repository where it is
maintained.

I've gone with what Niels requested rather than trying to over-analyze
what is going on. That matches what they do in Fedora, which is where
both Plymouth and systemd originated, so presumably they're getting
this more or less right.

While testing the resulting package, using openbox as a minimal "desktop
environment", I found that stopping nodm during shutdown does not work
as expected: it just hangs until systemd times out after 90 seconds.
I think this is a regression caused by the native systemd unit: systemd
sends SIGTERM to all processes in the service cgroup by default, then
waits up to 90 seconds and sends SIGKILL to any survivors, whereas
the LSB init script used start-stop-daemon --retry=10, which would
send SIGTERM to only the main process, wait up to 10 seconds and send
SIGKILL.

I've included a patch that makes the sysvinit service imitate the
LSB init script, which seems to resolve the 90 second hang. Niels, would
that be acceptable for an unblock, or do you want me to revert it?

Patches attached, also available from:
git fetch git+ssh://git.debian.org/git/users/smcv/nodm.git bug860463

Thanks,
    S
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Order-nodm.service-after-plymouth-quit.service.patch
Type: text/x-diff
Size: 2480 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20170427/2d0fde7c/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-d-nodm.init-Ask-Plymouth-to-stop-before-starting-nod.patch
Type: text/x-diff
Size: 1348 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20170427/2d0fde7c/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Make-systemd-service-shutdown-sequence-resemble-LSB-.patch
Type: text/x-diff
Size: 3240 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20170427/2d0fde7c/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Remove-myself-from-Uploaders.patch
Type: text/x-diff
Size: 1306 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20170427/2d0fde7c/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Non-maintainer-upload.patch
Type: text/x-diff
Size: 989 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20170427/2d0fde7c/attachment-0004.patch>