[pkg-fso-maint] Bug#853574: nodm: ftbfs with GCC-7

[Matthias Klose]

Package: src:nodm
Version: 0.13-1
Severity: normal
Tags: sid buster
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-7

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-7/g++-7, but succeeds to build with gcc-6/g++-6. The
severity of this report may be raised before the buster release.
There is no need to fix this issue in time for the stretch release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc7-20170126/nodm_0.13-1_unstable_gcc7.log
The last lines of the build log are at the end of this report.

To build with GCC 7, either set CC=gcc-7 CXX=g++-7 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-7/porting_to.html

[...]
checking for gcc option to accept ISO C99... none needed
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for X11... yes
checking for pam_start in -lpam... yes
checking for main in -lpam_misc... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: executing depfiles commands
configure: WARNING: unrecognized options: --disable-maintainer-mode
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_build
	make -j1
make[1]: Entering directory '/<<PKGBUILDDIR>>'
make  all-am
make[2]: Entering directory '/<<PKGBUILDDIR>>'
gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -DNODM_SESSION='"/usr/sbin/nodm"' -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Werror -c -o nodm-common.o `test -f 'common.c' || echo './'`common.c
gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -DNODM_SESSION='"/usr/sbin/nodm"' -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Werror -c -o nodm-log.o `test -f 'log.c' || echo './'`log.c
gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -DNODM_SESSION='"/usr/sbin/nodm"' -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Werror -c -o nodm-vt.o `test -f 'vt.c' || echo './'`vt.c
vt.c: In function 'nodm_vt_start':
vt.c:94:35: error: '%d' directive output may be truncated writing between 1 and 11 bytes into a region of size 7 [-Werror=format-truncation=]
     snprintf(vtname, 15, "/dev/tty%d", vtnum);
                                   ^~
vt.c:94:26: note: using the range [1, -2147483648] for directive argument
     snprintf(vtname, 15, "/dev/tty%d", vtnum);
                          ^~~~~~~~~~~~
In file included from /usr/include/stdio.h:938:0,
                 from vt.c:32:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: note: format output between 10 and 20 bytes into a destination of size 15
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Makefile:795: recipe for target 'nodm-vt.o' failed
make[2]: *** [nodm-vt.o] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
Makefile:592: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: make -j1 returned exit code 2
debian/rules:8: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2