[pkg-fso-maint] Bug#874175: libfsoframework: please include needed header files

Gianfranco Costamagna locutusofborg at debian.org
Sun Sep 3 20:06:30 UTC 2017


Source: libfsoframework
Version: 0.12.0-8
Severity: important
tags: patch

Hello, can you please consider adding this patch to the package (and forward upstream)?

  * Fix missing include of netlink/route/addr.h, resulting in FTBFS on
    64-bit platforms.

e.g.
https://launchpadlibrarian.net/232311089/buildlog_ubuntu-xenial-amd64.libfsoframework_0.12.0-7_BUILDING.txt.gz

Function `rtnl_addr_get_local' implicitly converted to pointer at netlinknotifier.c:1002
Function `rtnl_addr_get_peer' implicitly converted to pointer at netlinknotifier.c:1017
Function `rtnl_addr_get_broadcast' implicitly converted to pointer at netlinknotifier.c:1032
Function `rtnl_addr_get_anycast' implicitly converted to pointer at netlinknotifier.c:1047
Function `rtnl_addr_get_multicast' implicitly converted to pointer at netlinknotifier.c:1062
Function `rtnl_addr_get_label' implicitly converted to pointer at netlinknotifier.c:1111
Function `rtnl_addr_flags2str' implicitly converted to pointer at netlinknotifier.c:1120



Description:  Fix missing include of netlink/route/addr.h, resulting in FTBFS on 64-bit platforms.
Author: Dimitri John Ledkov <xnox at ubuntu.com>

--- libfsoframework-0.12.0.orig/fsobasics/netlinknotifier.vala
+++ libfsoframework-0.12.0/fsobasics/netlinknotifier.vala
@@ -275,6 +275,9 @@ public class FsoFramework.BaseNetlinkNot
 
     protected void fillAddressProperties( Netlink.Address addr, ref HashTable<string, string> properties )
     {
+	// trigger inclusion of netlink/route/addr.h
+	var unused = new Netlink.RouteAddress();
+	
         properties.insert( "ADDR_FAMILY", Netlink.af2Str( addr.get_family(), buffer ) );
 
         var local = addr.get_local();

attached the patch.


thanks for considering it,

Gianfranco
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-missing-include.patch
Type: text/x-patch
Size: 682 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20170903/331b8d79/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20170903/331b8d79/attachment.sig>


More information about the pkg-fso-maint mailing list