r14396 - in packages/trunk/kiki-the-nano-bot/debian: . patches

[Peter De Wachter]

Author: pdewacht-guest
Date: 2013-07-01 20:52:59 +0000 (Mon, 01 Jul 2013)
New Revision: 14396

Added:
   packages/trunk/kiki-the-nano-bot/debian/patches/virtual-destructors.patch
Modified:
   packages/trunk/kiki-the-nano-bot/debian/changelog
   packages/trunk/kiki-the-nano-bot/debian/patches/series
Log:
kiki-the-nano-bot: fix gcc undefined behavior warning


Modified: packages/trunk/kiki-the-nano-bot/debian/changelog
===================================================================
--- packages/trunk/kiki-the-nano-bot/debian/changelog	2013-07-01 20:36:21 UTC (rev 14395)
+++ packages/trunk/kiki-the-nano-bot/debian/changelog	2013-07-01 20:52:59 UTC (rev 14396)
@@ -1,13 +1,14 @@
-kiki-the-nano-bot (1.0.2+dfsg1-5) UNRELEASED; urgency=low
+kiki-the-nano-bot (1.0.2+dfsg1-5) unstable; urgency=low
 
   * Fixed FTBFS (incorrect python-config command) (Closes: #713274)
+  * Add virtual-destructors.patch to fix undefined behavior
   * Packaging cleanups
     - Switch to source format 3
     - Use build-hardening flags
     - Switch to debhelper 9
   * Bumped Standards-Version to 3.9.4.
 
- -- Peter De Wachter <pdewacht at gmail.com>  Mon, 24 Jun 2013 21:28:22 +0200
+ -- Peter De Wachter <pdewacht at gmail.com>  Mon, 01 Jul 2013 22:32:01 +0200
 
 kiki-the-nano-bot (1.0.2+dfsg1-4) unstable; urgency=low
 

Modified: packages/trunk/kiki-the-nano-bot/debian/patches/series
===================================================================
--- packages/trunk/kiki-the-nano-bot/debian/patches/series	2013-07-01 20:36:21 UTC (rev 14395)
+++ packages/trunk/kiki-the-nano-bot/debian/patches/series	2013-07-01 20:52:59 UTC (rev 14396)
@@ -21,3 +21,4 @@
 ogg-sound.patch
 level-selection-with-no-levels-solved.patch
 freebsd.patch
+virtual-destructors.patch

Added: packages/trunk/kiki-the-nano-bot/debian/patches/virtual-destructors.patch
===================================================================
--- packages/trunk/kiki-the-nano-bot/debian/patches/virtual-destructors.patch	                        (rev 0)
+++ packages/trunk/kiki-the-nano-bot/debian/patches/virtual-destructors.patch	2013-07-01 20:52:59 UTC (rev 14396)
@@ -0,0 +1,31 @@
+Description: add missing virtual destructors
+  GCC gives the following warning:
+  deleting object of polymorphic class type KObject/KikiCharacter which has
+  non-virtual destructor might cause undefined behaviour
+
+  Fix this by adding empty virtual destructors. The warning is probably
+  spurious for KikiCharacter but better safe than sorry.
+Author: Peter De Wachter <pdewacht at gmail.com>
+
+--- a/kodilib/src/tools/KNotificationObject.h
++++ b/kodilib/src/tools/KNotificationObject.h
+@@ -17,6 +17,9 @@
+ class KObject
+ {
+     INTROSPECTION
++
++public:
++    virtual ~KObject() { }
+ };
+ 
+ // --------------------------------------------------------------------------------------------------------
+--- a/src/gui/KikiCharacter.h
++++ b/src/gui/KikiCharacter.h
+@@ -20,6 +20,7 @@
+     public: // ........................................................................ PUBLIC
+     
+                         KikiCharacter	( char );
++    virtual             ~KikiCharacter	() { }
+     
+     virtual void 	display 	();
+     virtual void	render	 	();