[game-data-packager] 01/01: Fix logic error that made Wolf3D shareware regress

Simon McVittie smcv at debian.org
Thu Jan 15 23:53:34 UTC 2015


This is an automated email from the git hooks/post-receive script.

smcv pushed a commit to branch master
in repository game-data-packager.

commit 1e4ba83bec68d6f63a0accb3d85e3d5ffcaa3264
Author: Simon McVittie <smcv at debian.org>
Date:   Thu Jan 15 23:53:28 2015 +0000

    Fix logic error that made Wolf3D shareware regress
    
    After we call fill_gap, the status of that file is known; we don't
    have to "&" it with the previous status. The only thing we have
    to "&" is (first file is there & ... & last file is there) a couple
    of lines below.
---
 lib/game_data_packager/__init__.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/game_data_packager/__init__.py b/lib/game_data_packager/__init__.py
index f98bfa0..e6aef76 100644
--- a/lib/game_data_packager/__init__.py
+++ b/lib/game_data_packager/__init__.py
@@ -881,8 +881,8 @@ class GameData(object):
                     for alt in wanted.alternatives:
                         self.file_status[filename] |= self.file_status[alt]
                 else:
-                    self.file_status[filename] &= self.fill_gap(package,
-                            wanted, download=download, log=log)
+                    # updates file_status as a side-effect
+                    self.fill_gap(package, wanted, download=download, log=log)
 
             result &= self.file_status[filename]
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-games/game-data-packager.git



More information about the Pkg-games-commits mailing list