[openjk] 07/08: adjust patch wording

Simon McVittie smcv at debian.org
Fri May 8 22:45:00 UTC 2015


This is an automated email from the git hooks/post-receive script.

smcv pushed a commit to branch master
in repository openjk.

commit 05f2b62fe64bc965011c151fbf4d2c1c16541a1b
Author: Simon McVittie <smcv at debian.org>
Date:   Fri May 8 22:36:50 2015 +0100

    adjust patch wording
---
 debian/patches/mp3code-use-Q3-macros-for-endianness.patch | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/debian/patches/mp3code-use-Q3-macros-for-endianness.patch b/debian/patches/mp3code-use-Q3-macros-for-endianness.patch
index c185111..ddc1653 100644
--- a/debian/patches/mp3code-use-Q3-macros-for-endianness.patch
+++ b/debian/patches/mp3code-use-Q3-macros-for-endianness.patch
@@ -4,6 +4,14 @@ Subject: mp3code: use Q3 macros for endianness
 
 The mp3code came from Zinf (formerly FreeAmp) in which a similar
 endianness bug was fixed back in 2003 <https://bugs.debian.org/56472>.
+The bug is that the code uses LITTLE_ENDIAN as though it was a
+feature-test macro like Q3_LITTLE_ENDIAN, but actually it's
+always defined, regardless of platform: the actual test for
+endianness with <endian.h> is BYTE_ORDER == LITTLE_ENDIAN.
+As a result, it always takes the LE code path.
+
+Rather than trying to use <endian.h> in a portable way, I've just
+used the Quake 3 engine's equivalent macros.
 
 I'm surprised this wasn't fixed in JK2/JA already, since at least JK2
 ran on Mac back when that meant PowerPC, but perhaps changes from the

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-games/openjk.git



More information about the Pkg-games-commits mailing list