[Pkg-games-ubuntu] [Bug 663560] Re: libclaw FTBFS with GCC 4.5

[Krzysztof Klimonda]

The default constructor has the same name as Class' type so returning
claw::net::basic_socket::basic_socket* claw::net::basic_socket::close()
actually means "return the constructor" and not "return the type".

New version of gcc seems to complain about it.

The attached patch is similar to the patch created for libffado and few
other for other libraries.

** Patch added: "ftbfs.diff"
   https://bugs.edge.launchpad.net/ubuntu/+source/libclaw/+bug/663560/+attachment/1702169/+files/ftbfs.diff

-- 
libclaw FTBFS with GCC 4.5
https://bugs.launchpad.net/bugs/663560
You received this bug notification because you are a member of
Debian/Ubuntu Games Team, which is subscribed to libclaw in ubuntu.

Status in “libclaw” package in Ubuntu: New

Bug description:
-- Detecting CXX compiler ABI info - done
-- Found JPEG: /usr/lib/libjpeg.so
-- Found ZLIB: /usr/lib/libz.so
-- Found PNG: /usr/lib/libpng.so
-- Found Doxygen: /usr/bin/doxygen
-- Configuring done
-- Generating done
-- Build files have been written to: /build/user-libclaw_1.5.4-3-amd64-dpnjA2/libclaw-1.5.4/build-tree
touch configure-stamp
dh_testdir
cd /build/user-libclaw_1.5.4-3-amd64-dpnjA2/libclaw-1.5.4/build-tree; /usr/bin/make
make[1]: Entering directory `/build/user-libclaw_1.5.4-3-amd64-dpnjA2/libclaw-1.5.4/build-tree'
make[2]: Entering directory `/build/user-libclaw_1.5.4-3-amd64-dpnjA2/libclaw-1.5.4/build-tree'
make[3]: Entering directory `/build/user-libclaw_1.5.4-3-amd64-dpnjA2/libclaw-1.5.4/build-tree'
Scanning dependencies of target claw_logger
make[3]: Leaving directory `/build/user-libclaw_1.5.4-3-amd64-dpnjA2/libclaw-1.5.4/build-tree'
make[3]: Entering directory `/build/user-libclaw_1.5.4-3-amd64-dpnjA2/libclaw-1.5.4/build-tree'
[  1%] Building CXX object CMakeFiles/claw_logger.dir/claw/code/logger.o
In file included from /build/user-libclaw_1.5.4-3-amd64-dpnjA2/libclaw-1.5.4/./claw/logger.hpp:117:0,
                 from /build/user-libclaw_1.5.4-3-amd64-dpnjA2/libclaw-1.5.4/claw/code/logger.cpp:30:
/build/user-libclaw_1.5.4-3-amd64-dpnjA2/libclaw-1.5.4/./claw/impl/logger.tpp:39:1: error: 'claw::log_system::log_system' names the constructor, not the type
In file included from /usr/include/c++/4.5/utility:70:0,
                 from /usr/include/c++/4.5/algorithm:61,
                 from /build/user-libclaw_1.5.4-3-amd64-dpnjA2/libclaw-1.5.4/claw/code/logger.cpp:32:
/usr/include/c++/4.5/bits/stl_relops.h:67:1: error: expected unqualified-id before 'namespace'
make[3]: *** [CMakeFiles/claw_logger.dir/claw/code/logger.o] Error 1
make[2]: *** [CMakeFiles/claw_logger.dir/all] Error 2
make[1]: *** [all] Error 2
make: *** [build-stamp] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2