[Pkg-ganeti-devel] [PATCH] ganeti-instance-debian-etch initial packaging
Iustin Pop
iusty at k1024.org
Thu Feb 21 19:20:19 UTC 2008
On Thu, Feb 21, 2008 at 02:30:06PM +0100, Guido Trotter wrote:
> On Wed, Feb 20, 2008 at 09:30:26PM +0100, Iustin Pop wrote:
>
> Hi,
>
> > > Should the NOCACHE_FILE reside under /etc? It's tecnically configuration for
> > > this package.
> > Hmm, possibly yes, but then the changes to the upstream are a little bit
> > bigger (no-cache is not near the cache file anymore)...
> >
> > What I mean is that we would need a directory under /etc too, or even
> > better an /etc/defaults/ file, but this is even more changes.
> >
>
> I believe a directory under /etc... /etc/defaults is used just for init scripts,
> or am I wrong?
No, I think you're right.
> > > > +binary-install/ganeti-instance-debian-etch::
> > > > + install -d --mode 0755 $(CURDIR)/debian/ganeti-instance-debian-etch/usr/share/ganeti/os/debian-etch
> > >
> > > can we create this in debian/dirs too?
> > Oh, yeah, this is leftover from way back when I started packaging it :)
> >
> > Ok, the above is fixed, let me know what do you think about the /etc
> > file.
> >
>
> I believe it would be better to have it before upload as putting a configuration
> file under /var is an FHS violation. But you can just submit your patch and we
> can fix it in a second svn commit before uploading to the archive... I have no
> problem working on that if you like me to, and it's better for me to start with
> your patch already in.
Well, for now as a quick fix, I think I'll just move the nocache file
location to /etc/ganeti/instance-debian-etch, what do you think about
this location?
But for a proper fix, we should change the upstream, especially as we
should enhance this OS definition.
Here is the no-cache location patch:
Index: debian/patches/cache_in_var_cache.patch
===================================================================
--- debian/patches/cache_in_var_cache.patch (revision 39)
+++ debian/patches/cache_in_var_cache.patch (working copy)
@@ -8,7 +8,7 @@
-CACHE_FILE="cache-${DPKG_ARCH}.tar"
+CACHE_DIR="/var/cache/ganeti-instance-debian-etch"
+CACHE_FILE="$CACHE_DIR/cache-${DPKG_ARCH}.tar"
-+NOCACHE_FILE="$CACHE_DIR/no-cache"
++NOCACHE_FILE="/etc/ganeti/instance-debian-etch/no-cache"
TEMP=`getopt -o i:b:s: -n '$0' -- "$@"`
Index: debian/ganeti-instance-debian-etch.dirs
===================================================================
--- debian/ganeti-instance-debian-etch.dirs (revision 39)
+++ debian/ganeti-instance-debian-etch.dirs (working copy)
@@ -1,2 +1,3 @@
usr/share/ganeti/os/debian-etch
var/cache/ganeti-instance-debian-etch
+etc/ganeti/instance-debian-etch
Index: debian/README.Debian
===================================================================
--- debian/README.Debian (revision 39)
+++ debian/README.Debian (working copy)
@@ -3,4 +3,5 @@
/usr/share/ganeti/os/debian-etch), but under
/var/cache/ganeti-instance-debian-etch.
-The no-cache file also should be manually added under that directory.
+The no-cache file also should be added under the directory
+/etc/ganeti/instance-debian-etch if needed.
What do you think?
iustin
More information about the Pkg-ganeti-devel
mailing list