[Pkg-ganeti-devel] Bug#705005: ganeti2: missing dependency on fping in 2.6 package

[Ben Lipton]

Package: ganeti2
Version: 2.6.2-2
Severity: normal
Tags: experimental patch

The package for Ganeti 2.6 (in experimental) is missing a dependency on fping.  The dependency is listed in the INSTALL file, but not enforced in the debian/control file.

The effect of trying to run Ganeti 2.6 without fping is that the tools/master-ip-setup script will fail when trying to start the master daemon, producing the following error:

 * ganeti-masterd...
ERROR:root:Can't activate master IP address: Failed to start the master IP. Script return value: 1
   ...done.

This doesn't actually prevent the master daemon from launching, but it outputs unhelful errors when there are none. In addition to adding the dependency on fping to the package, it might also be worthwhile to add error checking to the script that would report when fping is missing.

The attached patch fixes the dependency side of this issue.

-- System Information:
Debian Release: 6.0.5
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

Versions of packages ganeti2 depends on:
ii  bridge-utils          1.4-5              Utilities for configuring the Linu
ii  iproute               20100519-3         networking and traffic control too
ii  iputils-arping        3:20100418-3       Tool to send ICMP echo requests to
ii  libjs-jquery          1.4.2-2            JavaScript library for dynamic web
ii  lvm2                  2.02.66-5          The Linux Logical Volume Manager
ii  openssh-client        1:5.5p1-6+squeeze3 secure shell (SSH) client, for sec
ii  openssh-server        1:5.5p1-6+squeeze3 secure shell (SSH) server, for sec
ii  openssl               0.9.8o-4squeeze14  Secure Socket Layer (SSL) binary a
ii  python                2.6.6-3+squeeze7   interactive high-level object-orie
ii  python-openssl        0.10-1             Python wrapper around the OpenSSL 
ii  python-paramiko       1.7.6-5            Make ssh v2 connections with Pytho
ii  python-pycurl         7.19.0-3+b1        Python bindings to libcurl
ii  python-pyinotify      0.8.9-1            simple Linux inotify Python bindin
ii  python-pyparsing      1.5.2-2            Python parsing module
ii  python-simplejson     2.1.1-1            simple, fast, extensible JSON enco
ii  python-support        1.0.10             automated rebuilding support for P
ii  socat                 1.7.1.3-1          multipurpose relay for bidirection

Versions of packages ganeti2 recommends:
pn  drbd8-utils                   <none>     (no description available)
pn  ganeti-instance-debootstrap   <none>     (no description available)
pn  ndisc6                        <none>     (no description available)
pn  qemu-kvm | xen-linux-system-2 <none>     (no description available)

Versions of packages ganeti2 suggests:
pn  drbd8-module-source           <none>     (no description available)

-- no debconf information
-------------- next part --------------
>From 4e520f742adc81396b84445b5657ad630f4741e4 Mon Sep 17 00:00:00 2001
From: Ben Lipton <ben.lipton at gmail.com>
Date: Mon, 8 Apr 2013 13:58:16 +0000
Subject: [PATCH] Add dependency on fping for tools/master-ip-setup

---
 debian/control |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/debian/control b/debian/control
index 9b06126..76409aa 100644
--- a/debian/control
+++ b/debian/control
@@ -23,7 +23,7 @@ Depends: ${shlibs:Depends}, ${misc:Depends}, ${python:Depends}, lvm2,
  openssh-client, openssh-server, bridge-utils, iproute, iputils-arping,
  openssl, python-simplejson, python-pyparsing, python-openssl,
  python-pyinotify, python-pycurl, python-paramiko,
- socat, libjs-jquery
+ socat, libjs-jquery, fping
 Recommends: drbd8-utils (>= 8.0.7), qemu-kvm |
  xen-linux-system-2.6.32-5-xen-amd64 | xen-linux-system-2.6.32-5-xen-686,
  ganeti-instance-debootstrap, ndisc6
-- 
1.7.2.5