[Pkg-ganeti-devel] Bug#882483: ganeti-instance-debootstrap: autopkgtest never passes

[Dimitri John Ledkov]

Package: ganeti-instance-debootstrap
Version: 0.16-3
Severity: normal
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Dear Maintainer,

The package ships autopkgtest but it can never work. Autopkgtests are
executed from unpacked but unconfigured/unbuilt tree. Although one can
trigger a built-tree to be created, I thought it's easier to just
configure/parse common.sh from common.sh.in without doing anything
else.

The test command executed was not not executed with srcdir set, thus
would bail.

The test produces output on stderr. I'm not sure if that is expected
or not, but I have whitelisted to allow stderr output. (By default
autopkgtest enfoces a failure, if any stderr is produced).

There is a bug in common.sh.in code, and fgrep command was incorrectly
invoked.

I've also added a test dependency on debian-archive-keyring, such that
debootstrap is validated.

With all of the above, I can manage to pass the test with an Ubuntu
qemu cloud image based runner.

Please consider applying attached fixed to your package.

Regards,

Dimitri.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJaFr1AAAoJEMrC2LnNLKX5k9MIAJ5SgX9w8lZitO86Y90aSR88
WAHT2Xinv1izZDAB1wo5Xpaa6M8T9cLeNUAgA2M8ATMo6GJslukFO4eoLPQsiyTO
FsWk8BVyKU+syH81YX2gsElZuRNq2/CMM7nLfwNSoUkF+jkSnTnJD+HA2eXm8PEU
fSbtgH6+tb+ZR6yp2VY2ZV3i2W1fTXh7W6Je9fLnNvnvSUAvVmYCGj6HqUoY2cfs
W6GgAP52gJDkuDT+vFcw/6nL3MFOHDEKX8BkqklKMmFdmo3L2aTg1k4F9TaYCYLN
sNl/RjyrGVy5X/yV413anFD9nCyd22PxsLFRJAI3LZOr3gy1dZoI3ilrkkFdu4c=
=trQG
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: autopkgtest-fixes.patch
Type: text/x-diff
Size: 3448 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ganeti-devel/attachments/20171123/eeccf10a/attachment.patch>