[Pkg-gauche-devel] Bug#891299: gauche-gtk: FTBFS with glibc 2.27: glgdGraph.c:25:42: error: 'HUGE' undeclared (first use in this function)

[Aurelien Jarno]

Package: gauche-gtk
Version: 0.6+git20160927-1
Severity: important
Tags: patch
User: debian-glibc at lists.debian.org
Usertags: 2.27

gauche-gtk 0.6+git20160927-1 fails to build with glibc 2.27 (2.27-0experimental0 from
experimental):

| glgdGraph.c:850:9: warning: 'pango_ft2_get_context' is deprecated: Use 'pango_font_map_create_context' instead [-Wdeprecated-declarations]
|          graph->pangoFT2Context = pango_ft2_get_context(_PANGO_DPI, _PANGO_DPI);
|          ^~~~~
| In file included from glgd.h:21:0,
|                  from gauche-glgd.h:26,
|                  from glgdGraph.c:12:
| /usr/include/pango-1.0/pango/pangoft2.h:122:20: note: declared here
|  PangoContext      *pango_ft2_get_context          (double dpi_x,
|                     ^~~~~~~~~~~~~~~~~~~~~
| glgdGraph.c: In function 'glgdGraphInit':
| glgdGraph.c:25:42: error: 'HUGE' undeclared (first use in this function)
|  #define _MAXFLT                         (HUGE)
|                                           ^
| glgdGraph.c:907:30: note: in expansion of macro '_MAXFLT'
|          graph->extents[0] = +_MAXFLT;
|                               ^~~~~~~
| glgdGraph.c:25:42: note: each undeclared identifier is reported only once for each function it appears in
|  #define _MAXFLT                         (HUGE)
|                                           ^
| glgdGraph.c:907:30: note: in expansion of macro '_MAXFLT'
|          graph->extents[0] = +_MAXFLT;
|                               ^~~~~~~
| glgdGraph.c: In function 'glgdGraphFini':
| glgdGraph.c:959:13: warning: 'pango_ft2_shutdown_display' is deprecated [-Wdeprecated-declarations]
|              pango_ft2_shutdown_display();
|              ^~~~~~~~~~~~~~~~~~~~~~~~~~
| In file included from glgd.h:21:0,
|                  from gauche-glgd.h:26,
|                  from glgdGraph.c:12:
| /usr/include/pango-1.0/pango/pangoft2.h:127:20: note: declared here
|  void               pango_ft2_shutdown_display     (void);
|                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
| glgdGraph.c:25:42: error: 'HUGE' undeclared (first use in this function)
|  #define _MAXFLT                         (HUGE)
|                                           ^
| glgdGraph.c:975:30: note: in expansion of macro '_MAXFLT'
|          graph->extents[0] = +_MAXFLT;
|                               ^~~~~~~
| glgdGraph.c: In function 'glgdGraphTranslate':
| glgdGraph.c:25:42: error: 'HUGE' undeclared (first use in this function)
|  #define _MAXFLT                         (HUGE)
|                                           ^
| glgdGraph.c:1165:30: note: in expansion of macro '_MAXFLT'
|          graph->extents[0] = +_MAXFLT;
|                               ^~~~~~~
| glgdGraph.c: In function 'glgdGraphAutoOrganize':
| glgdGraph.c:25:42: error: 'HUGE' undeclared (first use in this function)
|  #define _MAXFLT                         (HUGE)
|                                           ^
| glgdGraph.c:1205:30: note: in expansion of macro '_MAXFLT'
|          graph->extents[0] = +_MAXFLT;
|                               ^~~~~~~
| <builtin>: recipe for target 'glgdGraph.o' failed
| make[2]: *** [glgdGraph.o] Error 1
| make[2]: Leaving directory '/<<BUILDDIR>>/gauche-gtk-0.6+git20160927/glgd'
| Makefile:43: recipe for target 'all' failed
| make[1]: *** [all] Error 2
| make[1]: Leaving directory '/<<BUILDDIR>>/gauche-gtk-0.6+git20160927'
| dh_auto_build: make -j1 returned exit code 2
| debian/rules:9: recipe for target 'build-arch' failed
| make: *** [build-arch] Error 2
| dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2

A full build log is available there:
http://aws-logs.debian.net/2018/02/07/glibc-exp/gauche-gtk_0.6+git20160927-1_unstable_glibc-exp.log

Starting with glibc 2.27, support for SVID error handling has been
removed, including the corresponding HUGE constant. This causes this
package to FTBFS. The attached patch fixes that by always defining
_MAXFLT using HUGE_VAL instead of HUGE, like it is already the case
on mingw32.
-------------- next part --------------
diff -Nru gauche-gtk-0.6+git20160927/debian/patches/07-HUGE.patch gauche-gtk-0.6+git20160927/debian/patches/07-HUGE.patch
--- gauche-gtk-0.6+git20160927/debian/patches/07-HUGE.patch	1970-01-01 01:00:00.000000000 +0100
+++ gauche-gtk-0.6+git20160927/debian/patches/07-HUGE.patch	2018-02-24 11:47:11.000000000 +0100
@@ -0,0 +1,18 @@
+Description: replace HUGE by HUGE_VAL
+Author: Aurelien Jarno <aurelien at aurel32.net>
+Last-Update: 2018-02-24
+
+--- gauche-gtk-0.6+git20160927.orig/glgd/glgdGraph.c
++++ gauche-gtk-0.6+git20160927/glgd/glgdGraph.c
+@@ -19,11 +19,7 @@
+ #define GLGDGRAPH_CAMORBIT              (0)
+ #define GLGDGRAPH_NODENAME              (1)
+ #define GLGDGRAPH_LINKNAME              (2)
+-#ifdef __MINGW32__
+ #define _MAXFLT                         (HUGE_VAL)
+-#else  /*!__MINGW32__*/
+-#define _MAXFLT                         (HUGE)
+-#endif /*!__MINGW32__*/
+ #define _PANGO_DPI                      (72)
+ #define _PANGO_SCALE                    (3)
+ #define _TEXW                           (1024)
diff -Nru gauche-gtk-0.6+git20160927/debian/patches/series gauche-gtk-0.6+git20160927/debian/patches/series
--- gauche-gtk-0.6+git20160927/debian/patches/series	2016-10-26 04:37:15.000000000 +0200
+++ gauche-gtk-0.6+git20160927/debian/patches/series	2018-02-24 11:47:11.000000000 +0100
@@ -5,3 +5,4 @@
 # 04_new_gcc_cpp.patch
 05_install_755.patch
 06_gdk_pixbuf.patch
+07-HUGE.patch