[pkg-GD-devel] Bug#708413: Bug#708413: Causes FTBFS for pstoedit (probably others) due to stuff in header files

[Ondřej Surý]

Good catch. I have fixed this in upstream and it will be fixed in alpha2.

Ondrej

On Wed, May 15, 2013 at 5:48 PM, Roderich Schupp
<roderich.schupp at gmail.com> wrote:
> Package: libgd2-dev
> Version: 2.1.0~alpha1-1
> Severity: normal
> Tags: patch
>
> Trying to build pstoedit 3.62-1 with libgd2-dev  2.1.0~alpha1-1 results in:
>
> libtool: compile:  c++ -Wl,--as-needed -Wl,-O1 \
>   -DHAVE_CONFIG_H -I. -DHAVE_LIBPLOTTER -DHAVE_MKSTEMP \
>   -DHAVE_MAGIC -fopenmp -I/usr/include/ImageMagick -DHAVE_LIBPNG \
>   -DDEFAULTGS=/usr/bin/gs -DPSTOEDITDATADIR=\"/usr/share/pstoedit\" \
>   -DPSTOEDITLIBDIR=\"/usr/lib/x86_64-linux-gnu/pstoedit\" -DBUGGYGPP \
>   -pedantic -Wall -Wwrite-strings -Wcast-qual -Wpointer-arith -Wno-long-long \
>   -D_FORTIFY_SOURCE=2 -D_LITTLE_ENDIAN -g -O2 -fstack-protector \
>   --param=ssp-buffer-size=4 -Wformat -Werror=format-security -DINTERNALBOOL \
>   -c psimage.cpp  -fPIC -DPIC -o .libs/psimage.o
> In file included from /usr/include/gd.h:1105:0,
>                  from psimage.cpp:26:
> /usr/include/gdfx.h:9:20: fatal error: config.h: No such file or directory
>  #include "config.h"
>
>
> The problem is the following lines in /usr/include/gdfx.h
> ....
> #ifndef GDFX_H
> #define GDFX_H 1
>
> #ifdef HAVE_CONFIG_H             <<<
> #include "config.h"                  <<<
> #endif                                     <<<
>
> #include "gd.h"
> ....
>
> If a C source #include's <gd.h> (which in turn #include's <gdfx.h>) AND
> has #define'd HAVE_CONFIG_H (but the config file isn't actually named config.h)
> this will break.
> Also note the erroneous recursive #include of <gd.h>.
>
> Note that including "config.h" (present when building libgd2) isn't
> really necessary: AFAICT no source file of libgd2 includes gdfx.h
> by directly, only indirectly via gd.h. And any
>
> #include <gd.h>
>
> is typically preceded by
>
> #include "config.h"
>
> Suggested fix (patch attached) : drop the three lines from gdfx.h.
>
> Cheers, Roderich
>
>
>
>
>
>
>
>
>
> -- System Information:
> Debian Release: jessie/sid
>   APT prefers unstable
>   APT policy: (500, 'unstable'), (1, 'experimental')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
>
> Kernel: Linux 3.9.2 (SMP w/4 CPU cores)
> Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
>
> Versions of packages libgd2-dev depends on:
> ii  libfontconfig1-dev [libfontconfig-dev]  2.9.0-7.1
> ii  libfreetype6-dev                        2.4.9-1.1
> ii  libgd2-3                                2.1.0~alpha1-1
> ii  libjpeg8-dev [libjpeg-dev]              8d-1
> ii  libpng12-dev                            1.2.49-3
> ii  libtiff5-dev                            4.0.2-6
> ii  libvpx-dev                              1.1.0-1
> ii  libx11-dev                              2:1.5.0-1
> ii  libxpm-dev                              1:3.5.10-1
> ii  libxt-dev                               1:1.1.3-1
> ii  zlib1g-dev [libz-dev]                   1:1.2.8.dfsg-1
>
> libgd2-dev recommends no packages.
>
> libgd2-dev suggests no packages.
>
> -- no debconf information
>
> _______________________________________________
> pkg-GD-devel mailing list
> pkg-GD-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-gd-devel



-- 
Ondřej Surý <ondrej at sury.org>