[Pkg-glusterfs-devel] Bug#495312: glusterfs: Missing mode with open and O-CREAT

[Neil Wilson]

Package: glusterfs
Version: 1.3.10-1
Severity: serious
Tags: patch
Justification: no longer builds from source
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu hardy ubuntu-patch


Ubuntu has slightly tighter compiler constraints than Debian and has
thrown up an error in GlusterFS not picked up in the Debian build. The
attached patch plugs the hole.

*** /tmp/tmpkgK18J
In Ubuntu, we've applied the attached patch to achieve the following:

  * patches/10add_mode_to_open.patch - Add mode to open command to fix FTBFS

We thought you might be interested in doing the same. 


-- System Information:
Debian Release: lenny/sid
  APT prefers hardy-updates
  APT policy: (500, 'hardy-updates'), (500, 'hardy-security'), (500, 'hardy')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.24-19-generic (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
-------------- next part --------------
only in patch2:
unchanged:
--- glusterfs-1.3.10.orig/debian/patches/10add_mode_to_open.patch
+++ glusterfs-1.3.10/debian/patches/10add_mode_to_open.patch
@@ -0,0 +1,13 @@
+diff -Nur -x '*.orig' -x '*~' glusterfs/xlators/protocol/server/src/server-protocol.c glusterfs.new/xlators/protocol/server/src/server-protocol.c
+--- glusterfs/xlators/protocol/server/src/server-protocol.c	2008-07-17 09:19:55.000000000 +0100
++++ glusterfs.new/xlators/protocol/server/src/server-protocol.c	2008-08-13 19:23:17.000000000 +0100
+@@ -5353,7 +5353,8 @@
+     goto fail;
+   }
+   
+-  ret = open (GLUSTERFSD_SPEC_PATH, O_WRONLY | O_CREAT | O_SYNC);
++  ret = open (GLUSTERFSD_SPEC_PATH, 
++	      O_WRONLY | O_CREAT | O_SYNC, S_IRUSR | S_IWUSR);
+   spec_fd = ret;
+   if (spec_fd < 0){
+     remote_errno = errno;