r32324 - in /packages/unstable/gnome-video-arcade/debian: changelog patches/ patches/null_manufacturer.patch patches/series

[jordi at users.alioth.debian.org]

Author: jordi
Date: Wed Jan  4 20:54:39 2012
New Revision: 32324

URL: http://svn.debian.org/wsvn/pkg-gnome/?sc=1&rev=32324
Log:
null_manufacturer.patch: Remove NOT NULL constraint from "manufacturer"
column, to fix database rebuilds with MAME 0.144. Thanks to
Matthew Barnes <mbarnes at redhat.com>.

Added:
    packages/unstable/gnome-video-arcade/debian/patches/
    packages/unstable/gnome-video-arcade/debian/patches/null_manufacturer.patch
    packages/unstable/gnome-video-arcade/debian/patches/series
Modified:
    packages/unstable/gnome-video-arcade/debian/changelog

Modified: packages/unstable/gnome-video-arcade/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-gnome/packages/unstable/gnome-video-arcade/debian/changelog?rev=32324&op=diff
==============================================================================
--- packages/unstable/gnome-video-arcade/debian/changelog [utf-8] (original)
+++ packages/unstable/gnome-video-arcade/debian/changelog [utf-8] Wed Jan  4 20:54:39 2012
@@ -6,8 +6,11 @@
     (closes: #642456).
   * Update Vcs-* fields.
   * Watch for .xz tarballs.
+  * null_manufacturer.patch: Remove NOT NULL constraint from "manufacturer"
+    column, to fix database rebuilds with MAME 0.144. Thanks to
+    Matthew Barnes <mbarnes at redhat.com>.
 
- -- Jordi Mallach <jordi at debian.org>  Mon, 26 Dec 2011 03:01:45 +0100
+ -- Jordi Mallach <jordi at debian.org>  Wed, 04 Jan 2012 21:53:50 +0100
 
 gnome-video-arcade (0.8.0-2) unstable; urgency=low
 

Added: packages/unstable/gnome-video-arcade/debian/patches/null_manufacturer.patch
URL: http://svn.debian.org/wsvn/pkg-gnome/packages/unstable/gnome-video-arcade/debian/patches/null_manufacturer.patch?rev=32324&op=file
==============================================================================
--- packages/unstable/gnome-video-arcade/debian/patches/null_manufacturer.patch (added)
+++ packages/unstable/gnome-video-arcade/debian/patches/null_manufacturer.patch [utf-8] Wed Jan  4 20:54:39 2012
@@ -1,0 +1,35 @@
+From a6200b2e3b60da99cd069540a60a4f14172588ce Mon Sep 17 00:00:00 2001
+From: Matthew Barnes <mbarnes at redhat.com>
+Date: Wed, 04 Jan 2012 17:54:02 +0000
+Subject: Remove NOT NULL constraint from "manufacturer" column.
+
+MAME 0.144 introduces some <game> entries with no "manufacturer"
+attribute, which fails our "game" table constraint and causes the
+entire SQLite transaction to be rolled back.
+
+Most if not all of these appear to be non-runnable devices.
+
+e.g. <game name="bsmt2000" isdevice="yes" runnable="no">
+         <description>BSMT2000</description>
+         <rom name="bsmt2000.bin" ...>
+     </game>
+
+Indeed the -listxml DTD indicates the attribute is now optional:
+
+    <!ELEMENT game (... manufacturer? ...)>
+---
+diff --git a/src/gva-db.c b/src/gva-db.c
+index 275af3e..e8df9d1 100644
+--- a/src/gva-db.c
++++ b/src/gva-db.c
+@@ -63,7 +63,7 @@
+                 "('good', 'best available', 'bad')), " \
+                 "description NOT NULL, " \
+                 "year, " \
+-                "manufacturer NOT NULL, " \
++                "manufacturer, " \
+                 "sound_channels, " \
+                 "input_service DEFAULT 'no' " \
+                 "CHECK (input_service in ('yes', 'no')), " \
+--
+cgit v0.9.0.2

Added: packages/unstable/gnome-video-arcade/debian/patches/series
URL: http://svn.debian.org/wsvn/pkg-gnome/packages/unstable/gnome-video-arcade/debian/patches/series?rev=32324&op=file
==============================================================================
--- packages/unstable/gnome-video-arcade/debian/patches/series (added)
+++ packages/unstable/gnome-video-arcade/debian/patches/series [utf-8] Wed Jan  4 20:54:39 2012
@@ -1,0 +1,1 @@
+null_manufacturer.patch