r35921 - in /desktop/unstable/brasero/debian: changelog patches/02_fix-while-loop-in-libburnia-backend.patch patches/series

[biebl at users.alioth.debian.org]

Author: biebl
Date: Thu Oct 11 21:31:06 2012
New Revision: 35921

URL: http://svn.debian.org/wsvn/pkg-gnome/?sc=1&rev=35921
Log:
debian/patches/02_fix-while-loop-in-libburnia-backend.patch: Fix while
condition in libburnia backend which caused incomplete data to be written
to CD/DVD. Thanks Thomas Schmitt and Paul Menzel for the excellent
debugging and the patch. Closes: #688229

Added:
    desktop/unstable/brasero/debian/patches/02_fix-while-loop-in-libburnia-backend.patch
Modified:
    desktop/unstable/brasero/debian/changelog
    desktop/unstable/brasero/debian/patches/series

Modified: desktop/unstable/brasero/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-gnome/desktop/unstable/brasero/debian/changelog?rev=35921&op=diff
==============================================================================
--- desktop/unstable/brasero/debian/changelog [utf-8] (original)
+++ desktop/unstable/brasero/debian/changelog [utf-8] Thu Oct 11 21:31:06 2012
@@ -3,6 +3,10 @@
   * debian/patches/01_grafted_folders.patch: Fix a segfault when creating
     subfolders in a data project. Patch courtesy of Andrej Belym.
     Closes: #659061
+  * debian/patches/02_fix-while-loop-in-libburnia-backend.patch: Fix while
+    condition in libburnia backend which caused incomplete data to be written
+    to CD/DVD. Thanks Thomas Schmitt and Paul Menzel for the excellent
+    debugging and the patch. Closes: #688229
   * debian/patches/04_put-settings-in-the-correct-path.patch: Use correct
     schema path /org/gnome/brasero instead of /apps/brasero. Patch
     cherry-picked from upstream Git.

Added: desktop/unstable/brasero/debian/patches/02_fix-while-loop-in-libburnia-backend.patch
URL: http://svn.debian.org/wsvn/pkg-gnome/desktop/unstable/brasero/debian/patches/02_fix-while-loop-in-libburnia-backend.patch?rev=35921&op=file
==============================================================================
--- desktop/unstable/brasero/debian/patches/02_fix-while-loop-in-libburnia-backend.patch (added)
+++ desktop/unstable/brasero/debian/patches/02_fix-while-loop-in-libburnia-backend.patch [utf-8] Thu Oct 11 21:31:06 2012
@@ -1,0 +1,45 @@
+From 17ad074e2ad8e3881afae148594a770f3dd7f228 Mon Sep 17 00:00:00 2001
+From: Paul Menzel <paulepanter at users.sourceforge.net>
+Date: Thu, 11 Oct 2012 14:40:06 +0200
+Subject: [PATCH] Libburnia plugin: Fix while loop in `brasero_libisofs_write_image_to_fd_thread()` (#685983)
+
+In commit 1b8397ee [1] a bug was introduced by forgetting to
+substitude a command with a newly introduced variable in the loop
+condition. This broke the loop reading out the data to be written to the
+disc.
+
+This small error had a huge impacted as writing images on the fly always
+failed, because only half of the image was written to the disc. Several
+bug reports exist for this problem and are most likely due to this
+problem [3][4][5].
+
+Substituting this command with the variable fixes the problem reported
+in GNOME Bugzilla bug 685983 [6].
+
+[1] http://git.gnome.org/browse/brasero/commit/?id=1b8397ee252df2d554682ca2d694d5937fbf6e39
+[2] https://bugzilla.gnome.org/show_bug.cgi?id=630651
+[3] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=688229
+[4] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=594753
+[5] https://bugs.launchpad.net/ubuntu/+source/brasero/+bug/780117
+[6] https://bugzilla.gnome.org/show_bug.cgi?id=685983
+
+---
+ plugins/libburnia/burn-libisofs.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/plugins/libburnia/burn-libisofs.c b/plugins/libburnia/burn-libisofs.c
+index 22cb75e..841468a 100644
+--- a/plugins/libburnia/burn-libisofs.c
++++ b/plugins/libburnia/burn-libisofs.c
+@@ -199,7 +199,7 @@ brasero_libisofs_write_image_to_fd_thread (BraseroLibisofs *self)
+ 
+ 	BRASERO_JOB_LOG (self, "Writing to pipe");
+ 	read_bytes = priv->libburn_src->read_xt (priv->libburn_src, buf, sector_size);
+-	while (priv->libburn_src->read_xt (priv->libburn_src, buf, sector_size) == sector_size) {
++	while (read_bytes == sector_size) {
+ 		if (priv->cancel)
+ 			break;
+ 
+-- 
+1.7.10.4
+

Modified: desktop/unstable/brasero/debian/patches/series
URL: http://svn.debian.org/wsvn/pkg-gnome/desktop/unstable/brasero/debian/patches/series?rev=35921&op=diff
==============================================================================
--- desktop/unstable/brasero/debian/patches/series [utf-8] (original)
+++ desktop/unstable/brasero/debian/patches/series [utf-8] Thu Oct 11 21:31:06 2012
@@ -1,3 +1,4 @@
 01_grafted_folders.patch
+02_fix-while-loop-in-libburnia-backend.patch
 03_cue-invalid-frame-75.patch
 04_put-settings-in-the-correct-path.patch