r49935 - in /desktop/unstable/gnome-calendar/debian: changelog patches/0003-month-view-initialize-variable.patch patches/series
biebl at users.alioth.debian.org
biebl at users.alioth.debian.org
Thu Sep 1 11:01:17 UTC 2016
Author: biebl
Date: Thu Sep 1 11:01:17 2016
New Revision: 49935
URL: http://svn.debian.org/wsvn/pkg-gnome/?sc=1&rev=49935
Log:
Initialize timespan variable. This avoids build failures with gcc which is
over-pessimistic and aborts the build due to -Werror=maybe-uninitialized.
Patch cherry-picked from upstream Git.
Added:
desktop/unstable/gnome-calendar/debian/patches/0003-month-view-initialize-variable.patch
Modified:
desktop/unstable/gnome-calendar/debian/changelog
desktop/unstable/gnome-calendar/debian/patches/series
Modified: desktop/unstable/gnome-calendar/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-gnome/desktop/unstable/gnome-calendar/debian/changelog?rev=49935&op=diff
==============================================================================
--- desktop/unstable/gnome-calendar/debian/changelog [utf-8] (original)
+++ desktop/unstable/gnome-calendar/debian/changelog [utf-8] Thu Sep 1 11:01:17 2016
@@ -1,7 +1,13 @@
gnome-calendar (3.21.91-2) UNRELEASED; urgency=medium
+ [ Jeremy Bicha ]
* debian/control.in:
- Replace build-dependency on gnome-common with autoconf-archive
+
+ [ Michael Biebl ]
+ * Initialize timespan variable. This avoids build failures with gcc which is
+ over-pessimistic and aborts the build due to -Werror=maybe-uninitialized.
+ Patch cherry-picked from upstream Git.
-- Jeremy Bicha <jbicha at ubuntu.com> Thu, 01 Sep 2016 00:23:58 -0400
Added: desktop/unstable/gnome-calendar/debian/patches/0003-month-view-initialize-variable.patch
URL: http://svn.debian.org/wsvn/pkg-gnome/desktop/unstable/gnome-calendar/debian/patches/0003-month-view-initialize-variable.patch?rev=49935&op=file
==============================================================================
--- desktop/unstable/gnome-calendar/debian/patches/0003-month-view-initialize-variable.patch (added)
+++ desktop/unstable/gnome-calendar/debian/patches/0003-month-view-initialize-variable.patch [utf-8] Thu Sep 1 11:01:17 2016
@@ -0,0 +1,34 @@
+From 1b90c8b413286b3b8f841ee2090b5e0230d3641b Mon Sep 17 00:00:00 2001
+From: Dominique Leuenberger <dimstar at opensuse.org>
+Date: Wed, 31 Aug 2016 19:58:14 +0200
+Subject: [PATCH] month-view: initialize variable
+
+Some compilers seem to be over-pessimistic and abort the build with:
+
+ gcal-month-view.c: In function 'gcal_month_view_drag_drop':
+ gcal-month-view.c:908:32: error: 'timespan' may be used uninitialized in this function [-Werror=maybe-uninitialized]
+ GDateTime *new_end = g_date_time_add (new_start, timespan);
+
+Even though the usage of the variable is guarded by an equal if as the assignment
+
+https://bugzilla.gnome.org/show_bug.cgi?id=770667
+---
+ src/gcal-month-view.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/gcal-month-view.c b/src/gcal-month-view.c
+index 36f23a4..bb8fde2 100644
+--- a/src/gcal-month-view.c
++++ b/src/gcal-month-view.c
+@@ -865,7 +865,7 @@ gcal_month_view_drag_drop (GtkWidget *widget,
+ gint cell, diff;
+ gint start_month, current_month;
+ gint start_year, current_year;
+- GTimeSpan timespan;
++ GTimeSpan timespan = 0;
+
+ cell = get_dnd_cell (widget, x, y);
+ event_widget = gtk_drag_get_source_widget (context);
+--
+2.9.3
+
Modified: desktop/unstable/gnome-calendar/debian/patches/series
URL: http://svn.debian.org/wsvn/pkg-gnome/desktop/unstable/gnome-calendar/debian/patches/series?rev=49935&op=diff
==============================================================================
--- desktop/unstable/gnome-calendar/debian/patches/series [utf-8] (original)
+++ desktop/unstable/gnome-calendar/debian/patches/series [utf-8] Thu Sep 1 11:01:17 2016
@@ -1,2 +1,3 @@
0001-Hide-GOA-sources-on-Unity.patch
0002-Spawn-Ubuntu-s-credentials-panel-instead-of-the-GOA-.patch
+0003-month-view-initialize-variable.patch
More information about the pkg-gnome-commits
mailing list