[Pkg-gnu-smalltalk-devel] Bug#871077: gnu-smalltalk: FTBFS: configure: error: Synchronization primitives not found, please use a newer compiler.

[Gianfranco Costamagna]

control: tags -1 pending

Uploading shortly the following debdiff

thanks Adrian!

G.

On Thu, 1 Feb 2018 18:31:13 +0200 Adrian Bunk <bunk at debian.org> wrote:
> Control: tags -1 patch
> 
> On Sun, Aug 06, 2017 at 05:59:50PM -0400, Lucas Nussbaum wrote:
> >...
> > > checking for LIBFFI... yes
> > > checking for sigsegv_install_handler in -lsigsegv... no
> > > 
> > > Platform environment:
> > > checking whether the host supports __sync_fetch_and_add... no
> > > configure: error: Synchronization primitives not found, please use a newer compiler.
> > > debian/rules:16: recipe for target 'configure-stamp' failed
> >...
> 
> The actual error is according to config.log:
> cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
> 
> Fix:
> 
> --- debian/rules.old	2018-02-01 14:55:54.960603766 +0000
> +++ debian/rules	2018-02-01 14:58:04.752602528 +0000
> @@ -8,6 +8,7 @@
>  QUILT_STAMPFN = patch-stamp
>  include /usr/share/quilt/quilt.make
>  
> +export DEB_BUILD_MAINT_OPTIONS = hardening=-format
>  DPKG_EXPORT_BUILDFLAGS = 1
>  include /usr/share/dpkg/buildflags.mk
>  
> 
> There is now also a second build failure later related to Tcl 8.6,
> upstream fix for that is attached.
> 
> 
> cu
> Adrian
> 
> -- 
> 
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
> 
-------------- next part --------------
diff -u gnu-smalltalk-3.2.5/debian/changelog gnu-smalltalk-3.2.5/debian/changelog
--- gnu-smalltalk-3.2.5/debian/changelog
+++ gnu-smalltalk-3.2.5/debian/changelog
@@ -1,3 +1,13 @@
+gnu-smalltalk (3.2.5-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Adrian Bunk ]
+  * debian/patches/09_tcl_ftbfs.patch:
+    - fix build with new toolchain (Closes: #871077)
+
+ -- Gianfranco Costamagna <locutusofborg at debian.org>  Fri, 02 Feb 2018 17:40:01 +0100
+
 gnu-smalltalk (3.2.5-1) unstable; urgency=medium
 
   * Acknowledge NMU. Thanks Andreas!
diff -u gnu-smalltalk-3.2.5/debian/patches/series gnu-smalltalk-3.2.5/debian/patches/series
--- gnu-smalltalk-3.2.5/debian/patches/series
+++ gnu-smalltalk-3.2.5/debian/patches/series
@@ -6,0 +7 @@
+09_tcl_ftbfs.patch
diff -u gnu-smalltalk-3.2.5/debian/rules gnu-smalltalk-3.2.5/debian/rules
--- gnu-smalltalk-3.2.5/debian/rules
+++ gnu-smalltalk-3.2.5/debian/rules
@@ -8,6 +8,7 @@
 QUILT_STAMPFN = patch-stamp
 include /usr/share/quilt/quilt.make
 
+export DEB_BUILD_MAINT_OPTIONS = hardening=-format
 DPKG_EXPORT_BUILDFLAGS = 1
 include /usr/share/dpkg/buildflags.mk
 
only in patch2:
unchanged:
--- gnu-smalltalk-3.2.5.orig/debian/patches/09_tcl_ftbfs.patch
+++ gnu-smalltalk-3.2.5/debian/patches/09_tcl_ftbfs.patch
@@ -0,0 +1,51 @@
+From 84fc8a50f692624921d4233dec1a3c8796f5b5da Mon Sep 17 00:00:00 2001
+From: Holger Hans Peter Freyther <holger at freyther.de>
+Date: Mon, 26 May 2014 07:53:05 +0200
+Subject: blox: Direct usage of result is deprecated and stops working
+
+Use Tcl_GetStringResult(interp) instead of interp->result on
+newer versions of Tcl. It looks like Tcl_GetStringResult has
+been present in the entire 8.0 series.
+
+2014-05-26  Holger Hans Peter Freyther  <holger at moiji-mobile.com>
+
+	* BloxTK.c: Use Tcl_GetStringResult to access the result.
+---
+ packages/blox/tk/BloxTK.c  | 4 ++--
+ packages/blox/tk/ChangeLog | 4 ++++
+ 2 files changed, 6 insertions(+), 2 deletions(-)
+
+diff --git a/packages/blox/tk/BloxTK.c b/packages/blox/tk/BloxTK.c
+index 2ba40b81..2f06b7f0 100644
+--- a/packages/blox/tk/BloxTK.c
++++ b/packages/blox/tk/BloxTK.c
+@@ -173,12 +173,12 @@ tclInit (void)
+ 
+   if (Tcl_Init (interp) == TCL_ERROR)
+     {
+-      fprintf (stderr, "Tcl_Init failed: %s\n", interp->result);
++      fprintf (stderr, "Tcl_Init failed: %s\n",  Tcl_GetStringResult(interp));
+       exit (1);
+     }
+   if (Tk_Init (interp) == TCL_ERROR)
+     {
+-      fprintf (stderr, "Tk_Init failed: %s\n", interp->result);
++      fprintf (stderr, "Tk_Init failed: %s\n", Tcl_GetStringResult(interp));
+       exit (1);
+     }
+   Tcl_CreateCommand (interp, "callback", doCallback, NULL, NULL);
+diff --git a/packages/blox/tk/ChangeLog b/packages/blox/tk/ChangeLog
+index aefd2dcb..159b1776 100644
+--- a/packages/blox/tk/ChangeLog
++++ b/packages/blox/tk/ChangeLog
+@@ -1,3 +1,7 @@
++2014-05-26  Holger Hans Peter Freyther  <holger at moiji-mobile.com>
++
++	* BloxTK.c: Use Tcl_GetStringResult to access the result.
++
+ 2010-12-04  Paolo Bonzini  <bonzini at gnu.org>
+ 
+ 	* package.xml: Remove now superfluous <file> tags.
+-- 
+2.11.0
+
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnu-smalltalk-devel/attachments/20180202/adcee680/attachment.sig>