[Pkg-gnupg-commit] [gnupg2] 01/09: avoid shipping or trying to use .skel files

Daniel Kahn Gillmor dkg at fifthhorseman.net
Thu May 11 02:43:35 UTC 2017


This is an automated email from the git hooks/post-receive script.

dkg pushed a commit to branch experimental
in repository gnupg2.

commit 41b69e8a0c1f249402f12ade9c5fddbbfa716c0f
Author: Daniel Kahn Gillmor <dkg at fifthhorseman.net>
Date:   Mon Apr 17 11:54:03 2017 -0400

    avoid shipping or trying to use .skel files
---
 ... 0013-agent-Minor-fix-for-get_client_pid.patch} |   0
 ...0014-gpgscm-Simplify-substring-operation.patch} |   0
 ...scm-Simplify-get-output-string-operation.patch} |   0
 ....patch => 0016-gpgscm-Fix-copying-values.patch} |   0
 ...s-Fix-setup-of-ephemeral-home-directories.patch | 133 ------
 ...s-Fix-setup-of-ephemeral-home-directories.patch | 132 +++++-
 ...-Fix-setup-of-ephemeral-home-directories.patch} |   0
 ...atch => 0019-tests-Make-test-more-robust.patch} |   0
 ...pgscm-Initialize-unused-slots-in-vectors.patch} |   0
 ...ch => 0021-gpgscm-Avoid-mutating-integer.patch} |   0
 ...ent-Serialize-access-to-passphrase-cache.patch} |   0
 ...ep-CCID-reader-open-when-card-is-not-ava.patch} |   0
 ...=> 0024-scd-Internal-CCID-reader-cleanup.patch} |   0
 ...gpg-Fix-printing-of-offline-taken-subkey.patch} |   0
 ...=> 0026-doc-Explain-the-in-a-key-listing.patch} |   2 +-
 ... 0027-gpgscm-Fix-compact-vector-encoding.patch} |   0
 ...e-arbitrary-limit-on-number-of-cell-segm.patch} |   0
 ...-Make-global-data-constant-when-possible.patch} |   0
 ...ate-small-integers-in-the-rodata-section.patch} |   0
 debian/patches/series                              |  35 +-
 .../0012-g10-remove-skeleton-options-files.patch   | 444 +++++++++++++++++++++
 21 files changed, 580 insertions(+), 166 deletions(-)

diff --git a/debian/patches/0012-agent-Minor-fix-for-get_client_pid.patch b/debian/patches/0013-agent-Minor-fix-for-get_client_pid.patch
similarity index 100%
rename from debian/patches/0012-agent-Minor-fix-for-get_client_pid.patch
rename to debian/patches/0013-agent-Minor-fix-for-get_client_pid.patch
diff --git a/debian/patches/0013-gpgscm-Simplify-substring-operation.patch b/debian/patches/0014-gpgscm-Simplify-substring-operation.patch
similarity index 100%
rename from debian/patches/0013-gpgscm-Simplify-substring-operation.patch
rename to debian/patches/0014-gpgscm-Simplify-substring-operation.patch
diff --git a/debian/patches/0014-gpgscm-Simplify-get-output-string-operation.patch b/debian/patches/0015-gpgscm-Simplify-get-output-string-operation.patch
similarity index 100%
rename from debian/patches/0014-gpgscm-Simplify-get-output-string-operation.patch
rename to debian/patches/0015-gpgscm-Simplify-get-output-string-operation.patch
diff --git a/debian/patches/0015-gpgscm-Fix-copying-values.patch b/debian/patches/0016-gpgscm-Fix-copying-values.patch
similarity index 100%
rename from debian/patches/0015-gpgscm-Fix-copying-values.patch
rename to debian/patches/0016-gpgscm-Fix-copying-values.patch
diff --git a/debian/patches/0016-tests-Fix-setup-of-ephemeral-home-directories.patch b/debian/patches/0016-tests-Fix-setup-of-ephemeral-home-directories.patch
deleted file mode 100644
index 61394e7..0000000
--- a/debian/patches/0016-tests-Fix-setup-of-ephemeral-home-directories.patch
+++ /dev/null
@@ -1,133 +0,0 @@
-From: Justus Winter <justus at g10code.com>
-Date: Tue, 4 Apr 2017 14:32:04 +0200
-Subject: tests: Fix setup of ephemeral home directories.
-
-* tests/openpgp/defs.scm (with-ephemeral-home-directory): Create
-configuration files when we enter the context.
-* tests/openpgp/setup.scm: Do not use an ephemeral home directory.
-Tests should always use the cwd.
-* tests/gpgsm/setup.scm: Likewise.
-* tests/gpgsm/export.scm: Add explicit constructor function.
-* tests/openpgp/decrypt-session-key.scm: Likewise.
-* tests/openpgp/decrypt-unwrap-verify.scm: Likewise.
---
-
-Previously, ephemeral homedirectories lacked a configuration, hence
-GnuPG tried to start backend daemons using their installed locations.
-Fix this by explicitly creating a suitable configuration.
-
-GnuPG-bug-id: 3047
-Signed-off-by: Justus Winter <justus at g10code.com>
-(cherry picked from commit 32b75fb7743f35936d7014fce33c90ba97dfa374)
----
- tests/gpgsm/export.scm                  |  2 +-
- tests/gpgsm/setup.scm                   |  8 +++-----
- tests/openpgp/decrypt-session-key.scm   |  2 +-
- tests/openpgp/decrypt-unwrap-verify.scm |  2 +-
- tests/openpgp/defs.scm                  | 12 ++++++++----
- tests/openpgp/setup.scm                 | 13 ++++++-------
- 6 files changed, 20 insertions(+), 19 deletions(-)
-
-diff --git a/tests/gpgsm/export.scm b/tests/gpgsm/export.scm
-index 1ee91e4..47fb06e 100644
---- a/tests/gpgsm/export.scm
-+++ b/tests/gpgsm/export.scm
-@@ -25,7 +25,7 @@
-  (lambda (cert)
-    (lettmp (exported)
-      (call-check `(, at gpgsm --output ,exported --export ,cert::uid::CN))
--     (with-ephemeral-home-directory
-+     (with-ephemeral-home-directory setup-gpgsm-environment
-       (call-check `(, at gpgsm --import ,exported))
-       (assert (sm-have-public-key? cert)))))
-  (lambda (cert) cert::uid::CN)
-diff --git a/tests/gpgsm/setup.scm b/tests/gpgsm/setup.scm
-index 91821a0..aa1ab41 100644
---- a/tests/gpgsm/setup.scm
-+++ b/tests/gpgsm/setup.scm
-@@ -23,8 +23,6 @@
- (unless (and tarball (not (null? tarball)))
- 	(error "Usage: setup.scm --create-tarball <file> ..."))
- 
--(with-ephemeral-home-directory
-- (chdir (getenv "GNUPGHOME"))
-- (create-gpgsmhome)
-- (stop-agent)
-- (call-check `(,(tool 'gpgtar) --create --output ,(car tarball) ".")))
-+(setenv "GNUPGHOME" (getcwd) #t)
-+(create-gpgsmhome)
-+(call-check `(,(tool 'gpgtar) --create --output ,(car tarball) "."))
-diff --git a/tests/openpgp/decrypt-session-key.scm b/tests/openpgp/decrypt-session-key.scm
-index 771b53d..989ce30 100755
---- a/tests/openpgp/decrypt-session-key.scm
-+++ b/tests/openpgp/decrypt-session-key.scm
-@@ -37,7 +37,7 @@
-  (lambda (name)
-    (let* ((source (in-srcdir (string-append name ".asc")))
- 	  (key (get-session-key source)))
--     (with-ephemeral-home-directory
-+     (with-ephemeral-home-directory setup-environment
-       (tr:do
-        (tr:open source)
-        (tr:gpg "" `(--yes --decrypt --override-session-key ,key))
-diff --git a/tests/openpgp/decrypt-unwrap-verify.scm b/tests/openpgp/decrypt-unwrap-verify.scm
-index 97a72e4..ef9a99a 100755
---- a/tests/openpgp/decrypt-unwrap-verify.scm
-+++ b/tests/openpgp/decrypt-unwrap-verify.scm
-@@ -35,7 +35,7 @@
- 
-        ;; Then, verify the signature with a clean working directory
-        ;; containing only Steve's public key.
--       (with-ephemeral-home-directory
-+       (with-ephemeral-home-directory setup-environment
- 	(call-check `(, at gpg --import ,steve's-key))
- 	(call-check `(, at gpg --verify ,unwrapped)))))
-   '("encsig-2-keys-3" "encsig-2-keys-4")))
-diff --git a/tests/openpgp/defs.scm b/tests/openpgp/defs.scm
-index e8d06c0..4271ba0 100644
---- a/tests/openpgp/defs.scm
-+++ b/tests/openpgp/defs.scm
-@@ -289,14 +289,18 @@
- 
- ;; Evaluate a sequence of expressions with an ephemeral home
- ;; directory.
--(define-macro (with-ephemeral-home-directory . expressions)
-+(define-macro (with-ephemeral-home-directory setup-fn . expressions)
-   (let ((original-home-directory (gensym))
--	(ephemeral-home-directory (gensym)))
-+	(ephemeral-home-directory (gensym))
-+	(setup (gensym)))
-     `(let ((,original-home-directory (getenv "GNUPGHOME"))
--	   (,ephemeral-home-directory (mkdtemp)))
-+	   (,ephemeral-home-directory (mkdtemp))
-+	   (,setup (delay (,setup-fn))))
-        (finally (unlink-recursively ,ephemeral-home-directory)
- 	 (dynamic-wind
--	     (lambda () (setenv "GNUPGHOME" ,ephemeral-home-directory #t))
-+	     (lambda ()
-+	       (force ,setup)
-+	       (setenv "GNUPGHOME" ,ephemeral-home-directory #t))
- 	     (lambda () , at expressions)
- 	     (lambda () (setenv "GNUPGHOME" ,original-home-directory #t)))))))
- 
-diff --git a/tests/openpgp/setup.scm b/tests/openpgp/setup.scm
-index 4b3bfcb..a7d14e7 100755
---- a/tests/openpgp/setup.scm
-+++ b/tests/openpgp/setup.scm
-@@ -40,10 +40,9 @@
-        '(gpgconf gpg gpg-agent scdaemon gpgsm dirmngr gpg-connect-agent
- 		 gpg-preset-passphrase gpgtar pinentry)))
- 
--(with-ephemeral-home-directory
-- (chdir (getenv "GNUPGHOME"))
-- (create-gpghome)
-- (start-agent)
-- (create-legacy-gpghome)
-- (stop-agent)
-- (call-check `(,(tool 'gpgtar) --create --output ,(cadr *args*) ".")))
-+(setenv "GNUPGHOME" (getcwd) #t)
-+(create-gpghome)
-+(start-agent)
-+(create-legacy-gpghome)
-+(stop-agent)
-+(call-check `(,(tool 'gpgtar) --create --output ,(cadr *args*) "."))
diff --git a/debian/patches/0017-tests-Fix-setup-of-ephemeral-home-directories.patch b/debian/patches/0017-tests-Fix-setup-of-ephemeral-home-directories.patch
index a0bd43e..61394e7 100644
--- a/debian/patches/0017-tests-Fix-setup-of-ephemeral-home-directories.patch
+++ b/debian/patches/0017-tests-Fix-setup-of-ephemeral-home-directories.patch
@@ -1,31 +1,133 @@
 From: Justus Winter <justus at g10code.com>
-Date: Wed, 5 Apr 2017 15:18:30 +0200
+Date: Tue, 4 Apr 2017 14:32:04 +0200
 Subject: tests: Fix setup of ephemeral home directories.
 
-* tests/openpgp/defs.scm (with-ephemeral-home-directory): Set
-GNUPGHOME and cwd to the ephemeral directory before calling the setup
-function.
+* tests/openpgp/defs.scm (with-ephemeral-home-directory): Create
+configuration files when we enter the context.
+* tests/openpgp/setup.scm: Do not use an ephemeral home directory.
+Tests should always use the cwd.
+* tests/gpgsm/setup.scm: Likewise.
+* tests/gpgsm/export.scm: Add explicit constructor function.
+* tests/openpgp/decrypt-session-key.scm: Likewise.
+* tests/openpgp/decrypt-unwrap-verify.scm: Likewise.
+--
+
+Previously, ephemeral homedirectories lacked a configuration, hence
+GnuPG tried to start backend daemons using their installed locations.
+Fix this by explicitly creating a suitable configuration.
 
 GnuPG-bug-id: 3047
-Fixes-commit: 32b75fb7743f35936d7014fce33c90ba97dfa374
 Signed-off-by: Justus Winter <justus at g10code.com>
-(cherry picked from commit 01e84d429aeeb1450012ff0576a6a24de50693c6)
+(cherry picked from commit 32b75fb7743f35936d7014fce33c90ba97dfa374)
 ---
- tests/openpgp/defs.scm | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
+ tests/gpgsm/export.scm                  |  2 +-
+ tests/gpgsm/setup.scm                   |  8 +++-----
+ tests/openpgp/decrypt-session-key.scm   |  2 +-
+ tests/openpgp/decrypt-unwrap-verify.scm |  2 +-
+ tests/openpgp/defs.scm                  | 12 ++++++++----
+ tests/openpgp/setup.scm                 | 13 ++++++-------
+ 6 files changed, 20 insertions(+), 19 deletions(-)
 
+diff --git a/tests/gpgsm/export.scm b/tests/gpgsm/export.scm
+index 1ee91e4..47fb06e 100644
+--- a/tests/gpgsm/export.scm
++++ b/tests/gpgsm/export.scm
+@@ -25,7 +25,7 @@
+  (lambda (cert)
+    (lettmp (exported)
+      (call-check `(, at gpgsm --output ,exported --export ,cert::uid::CN))
+-     (with-ephemeral-home-directory
++     (with-ephemeral-home-directory setup-gpgsm-environment
+       (call-check `(, at gpgsm --import ,exported))
+       (assert (sm-have-public-key? cert)))))
+  (lambda (cert) cert::uid::CN)
+diff --git a/tests/gpgsm/setup.scm b/tests/gpgsm/setup.scm
+index 91821a0..aa1ab41 100644
+--- a/tests/gpgsm/setup.scm
++++ b/tests/gpgsm/setup.scm
+@@ -23,8 +23,6 @@
+ (unless (and tarball (not (null? tarball)))
+ 	(error "Usage: setup.scm --create-tarball <file> ..."))
+ 
+-(with-ephemeral-home-directory
+- (chdir (getenv "GNUPGHOME"))
+- (create-gpgsmhome)
+- (stop-agent)
+- (call-check `(,(tool 'gpgtar) --create --output ,(car tarball) ".")))
++(setenv "GNUPGHOME" (getcwd) #t)
++(create-gpgsmhome)
++(call-check `(,(tool 'gpgtar) --create --output ,(car tarball) "."))
+diff --git a/tests/openpgp/decrypt-session-key.scm b/tests/openpgp/decrypt-session-key.scm
+index 771b53d..989ce30 100755
+--- a/tests/openpgp/decrypt-session-key.scm
++++ b/tests/openpgp/decrypt-session-key.scm
+@@ -37,7 +37,7 @@
+  (lambda (name)
+    (let* ((source (in-srcdir (string-append name ".asc")))
+ 	  (key (get-session-key source)))
+-     (with-ephemeral-home-directory
++     (with-ephemeral-home-directory setup-environment
+       (tr:do
+        (tr:open source)
+        (tr:gpg "" `(--yes --decrypt --override-session-key ,key))
+diff --git a/tests/openpgp/decrypt-unwrap-verify.scm b/tests/openpgp/decrypt-unwrap-verify.scm
+index 97a72e4..ef9a99a 100755
+--- a/tests/openpgp/decrypt-unwrap-verify.scm
++++ b/tests/openpgp/decrypt-unwrap-verify.scm
+@@ -35,7 +35,7 @@
+ 
+        ;; Then, verify the signature with a clean working directory
+        ;; containing only Steve's public key.
+-       (with-ephemeral-home-directory
++       (with-ephemeral-home-directory setup-environment
+ 	(call-check `(, at gpg --import ,steve's-key))
+ 	(call-check `(, at gpg --verify ,unwrapped)))))
+   '("encsig-2-keys-3" "encsig-2-keys-4")))
 diff --git a/tests/openpgp/defs.scm b/tests/openpgp/defs.scm
-index 4271ba0..815a560 100644
+index e8d06c0..4271ba0 100644
 --- a/tests/openpgp/defs.scm
 +++ b/tests/openpgp/defs.scm
-@@ -299,8 +299,8 @@
+@@ -289,14 +289,18 @@
+ 
+ ;; Evaluate a sequence of expressions with an ephemeral home
+ ;; directory.
+-(define-macro (with-ephemeral-home-directory . expressions)
++(define-macro (with-ephemeral-home-directory setup-fn . expressions)
+   (let ((original-home-directory (gensym))
+-	(ephemeral-home-directory (gensym)))
++	(ephemeral-home-directory (gensym))
++	(setup (gensym)))
+     `(let ((,original-home-directory (getenv "GNUPGHOME"))
+-	   (,ephemeral-home-directory (mkdtemp)))
++	   (,ephemeral-home-directory (mkdtemp))
++	   (,setup (delay (,setup-fn))))
         (finally (unlink-recursively ,ephemeral-home-directory)
  	 (dynamic-wind
- 	     (lambda ()
--	       (force ,setup)
--	       (setenv "GNUPGHOME" ,ephemeral-home-directory #t))
-+	       (setenv "GNUPGHOME" ,ephemeral-home-directory #t)
-+	       (with-working-directory ,ephemeral-home-directory (force ,setup)))
+-	     (lambda () (setenv "GNUPGHOME" ,ephemeral-home-directory #t))
++	     (lambda ()
++	       (force ,setup)
++	       (setenv "GNUPGHOME" ,ephemeral-home-directory #t))
  	     (lambda () , at expressions)
  	     (lambda () (setenv "GNUPGHOME" ,original-home-directory #t)))))))
  
+diff --git a/tests/openpgp/setup.scm b/tests/openpgp/setup.scm
+index 4b3bfcb..a7d14e7 100755
+--- a/tests/openpgp/setup.scm
++++ b/tests/openpgp/setup.scm
+@@ -40,10 +40,9 @@
+        '(gpgconf gpg gpg-agent scdaemon gpgsm dirmngr gpg-connect-agent
+ 		 gpg-preset-passphrase gpgtar pinentry)))
+ 
+-(with-ephemeral-home-directory
+- (chdir (getenv "GNUPGHOME"))
+- (create-gpghome)
+- (start-agent)
+- (create-legacy-gpghome)
+- (stop-agent)
+- (call-check `(,(tool 'gpgtar) --create --output ,(cadr *args*) ".")))
++(setenv "GNUPGHOME" (getcwd) #t)
++(create-gpghome)
++(start-agent)
++(create-legacy-gpghome)
++(stop-agent)
++(call-check `(,(tool 'gpgtar) --create --output ,(cadr *args*) "."))
diff --git a/debian/patches/0017-tests-Fix-setup-of-ephemeral-home-directories.patch b/debian/patches/0018-tests-Fix-setup-of-ephemeral-home-directories.patch
similarity index 100%
copy from debian/patches/0017-tests-Fix-setup-of-ephemeral-home-directories.patch
copy to debian/patches/0018-tests-Fix-setup-of-ephemeral-home-directories.patch
diff --git a/debian/patches/0018-tests-Make-test-more-robust.patch b/debian/patches/0019-tests-Make-test-more-robust.patch
similarity index 100%
rename from debian/patches/0018-tests-Make-test-more-robust.patch
rename to debian/patches/0019-tests-Make-test-more-robust.patch
diff --git a/debian/patches/0019-gpgscm-Initialize-unused-slots-in-vectors.patch b/debian/patches/0020-gpgscm-Initialize-unused-slots-in-vectors.patch
similarity index 100%
rename from debian/patches/0019-gpgscm-Initialize-unused-slots-in-vectors.patch
rename to debian/patches/0020-gpgscm-Initialize-unused-slots-in-vectors.patch
diff --git a/debian/patches/0020-gpgscm-Avoid-mutating-integer.patch b/debian/patches/0021-gpgscm-Avoid-mutating-integer.patch
similarity index 100%
rename from debian/patches/0020-gpgscm-Avoid-mutating-integer.patch
rename to debian/patches/0021-gpgscm-Avoid-mutating-integer.patch
diff --git a/debian/patches/0021-agent-Serialize-access-to-passphrase-cache.patch b/debian/patches/0022-agent-Serialize-access-to-passphrase-cache.patch
similarity index 100%
rename from debian/patches/0021-agent-Serialize-access-to-passphrase-cache.patch
rename to debian/patches/0022-agent-Serialize-access-to-passphrase-cache.patch
diff --git a/debian/patches/0022-scd-Don-t-keep-CCID-reader-open-when-card-is-not-ava.patch b/debian/patches/0023-scd-Don-t-keep-CCID-reader-open-when-card-is-not-ava.patch
similarity index 100%
rename from debian/patches/0022-scd-Don-t-keep-CCID-reader-open-when-card-is-not-ava.patch
rename to debian/patches/0023-scd-Don-t-keep-CCID-reader-open-when-card-is-not-ava.patch
diff --git a/debian/patches/0023-scd-Internal-CCID-reader-cleanup.patch b/debian/patches/0024-scd-Internal-CCID-reader-cleanup.patch
similarity index 100%
rename from debian/patches/0023-scd-Internal-CCID-reader-cleanup.patch
rename to debian/patches/0024-scd-Internal-CCID-reader-cleanup.patch
diff --git a/debian/patches/0024-gpg-Fix-printing-of-offline-taken-subkey.patch b/debian/patches/0025-gpg-Fix-printing-of-offline-taken-subkey.patch
similarity index 100%
rename from debian/patches/0024-gpg-Fix-printing-of-offline-taken-subkey.patch
rename to debian/patches/0025-gpg-Fix-printing-of-offline-taken-subkey.patch
diff --git a/debian/patches/0025-doc-Explain-the-in-a-key-listing.patch b/debian/patches/0026-doc-Explain-the-in-a-key-listing.patch
similarity index 97%
rename from debian/patches/0025-doc-Explain-the-in-a-key-listing.patch
rename to debian/patches/0026-doc-Explain-the-in-a-key-listing.patch
index fd7d5bd..de74eae 100644
--- a/debian/patches/0025-doc-Explain-the-in-a-key-listing.patch
+++ b/debian/patches/0026-doc-Explain-the-in-a-key-listing.patch
@@ -11,7 +11,7 @@ Signed-off-by: Werner Koch <wk at gnupg.org>
  1 file changed, 7 insertions(+), 4 deletions(-)
 
 diff --git a/doc/gpg.texi b/doc/gpg.texi
-index 37e1ff1..c0d7cc4 100644
+index 1fa5381..aa55cb8 100644
 --- a/doc/gpg.texi
 +++ b/doc/gpg.texi
 @@ -301,10 +301,13 @@ and other programs.
diff --git a/debian/patches/0026-gpgscm-Fix-compact-vector-encoding.patch b/debian/patches/0027-gpgscm-Fix-compact-vector-encoding.patch
similarity index 100%
rename from debian/patches/0026-gpgscm-Fix-compact-vector-encoding.patch
rename to debian/patches/0027-gpgscm-Fix-compact-vector-encoding.patch
diff --git a/debian/patches/0027-gpgscm-Remove-arbitrary-limit-on-number-of-cell-segm.patch b/debian/patches/0028-gpgscm-Remove-arbitrary-limit-on-number-of-cell-segm.patch
similarity index 100%
rename from debian/patches/0027-gpgscm-Remove-arbitrary-limit-on-number-of-cell-segm.patch
rename to debian/patches/0028-gpgscm-Remove-arbitrary-limit-on-number-of-cell-segm.patch
diff --git a/debian/patches/0028-gpgscm-Make-global-data-constant-when-possible.patch b/debian/patches/0029-gpgscm-Make-global-data-constant-when-possible.patch
similarity index 100%
rename from debian/patches/0028-gpgscm-Make-global-data-constant-when-possible.patch
rename to debian/patches/0029-gpgscm-Make-global-data-constant-when-possible.patch
diff --git a/debian/patches/0029-gpgscm-Allocate-small-integers-in-the-rodata-section.patch b/debian/patches/0030-gpgscm-Allocate-small-integers-in-the-rodata-section.patch
similarity index 100%
rename from debian/patches/0029-gpgscm-Allocate-small-integers-in-the-rodata-section.patch
rename to debian/patches/0030-gpgscm-Allocate-small-integers-in-the-rodata-section.patch
diff --git a/debian/patches/series b/debian/patches/series
index 30d8f0f..4015799 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -9,21 +9,22 @@ gpg-agent-idling/0008-agent-Create-framework-of-scheduled-timers.patch
 gpg-agent-idling/0009-agent-Allow-threads-to-interrupt-main-select-loop-wi.patch
 gpg-agent-idling/0010-agent-Avoid-tight-timer-tick-when-possible.patch
 gpg-agent-idling/0011-agent-Avoid-scheduled-checks-on-socket-when-inotify-.patch
-0012-agent-Minor-fix-for-get_client_pid.patch
-0013-gpgscm-Simplify-substring-operation.patch
-0014-gpgscm-Simplify-get-output-string-operation.patch
-0015-gpgscm-Fix-copying-values.patch
-0016-tests-Fix-setup-of-ephemeral-home-directories.patch
+skel-file-removal/0012-g10-remove-skeleton-options-files.patch
+0013-agent-Minor-fix-for-get_client_pid.patch
+0014-gpgscm-Simplify-substring-operation.patch
+0015-gpgscm-Simplify-get-output-string-operation.patch
+0016-gpgscm-Fix-copying-values.patch
 0017-tests-Fix-setup-of-ephemeral-home-directories.patch
-0018-tests-Make-test-more-robust.patch
-0019-gpgscm-Initialize-unused-slots-in-vectors.patch
-0020-gpgscm-Avoid-mutating-integer.patch
-0021-agent-Serialize-access-to-passphrase-cache.patch
-0022-scd-Don-t-keep-CCID-reader-open-when-card-is-not-ava.patch
-0023-scd-Internal-CCID-reader-cleanup.patch
-0024-gpg-Fix-printing-of-offline-taken-subkey.patch
-0025-doc-Explain-the-in-a-key-listing.patch
-0026-gpgscm-Fix-compact-vector-encoding.patch
-0027-gpgscm-Remove-arbitrary-limit-on-number-of-cell-segm.patch
-0028-gpgscm-Make-global-data-constant-when-possible.patch
-0029-gpgscm-Allocate-small-integers-in-the-rodata-section.patch
+0018-tests-Fix-setup-of-ephemeral-home-directories.patch
+0019-tests-Make-test-more-robust.patch
+0020-gpgscm-Initialize-unused-slots-in-vectors.patch
+0021-gpgscm-Avoid-mutating-integer.patch
+0022-agent-Serialize-access-to-passphrase-cache.patch
+0023-scd-Don-t-keep-CCID-reader-open-when-card-is-not-ava.patch
+0024-scd-Internal-CCID-reader-cleanup.patch
+0025-gpg-Fix-printing-of-offline-taken-subkey.patch
+0026-doc-Explain-the-in-a-key-listing.patch
+0027-gpgscm-Fix-compact-vector-encoding.patch
+0028-gpgscm-Remove-arbitrary-limit-on-number-of-cell-segm.patch
+0029-gpgscm-Make-global-data-constant-when-possible.patch
+0030-gpgscm-Allocate-small-integers-in-the-rodata-section.patch
diff --git a/debian/patches/skel-file-removal/0012-g10-remove-skeleton-options-files.patch b/debian/patches/skel-file-removal/0012-g10-remove-skeleton-options-files.patch
new file mode 100644
index 0000000..5ae4458
--- /dev/null
+++ b/debian/patches/skel-file-removal/0012-g10-remove-skeleton-options-files.patch
@@ -0,0 +1,444 @@
+From: Daniel Kahn Gillmor <dkg at fifthhorseman.net>
+Date: Mon, 17 Apr 2017 10:51:55 -0400
+Subject: g10: remove skeleton options files
+
+* build-aux/speed/w32/inst.nsi: stop installing skeleton files.
+* doc/gpg.texi: stop documenting skeleton files.
+* g10/Makefile.am: stop installing skeleton files.
+* g10/openfile.c (copy_options_file): Remove.
+(try_make_homedir): do not call copy_options_file()
+
+The defaults for gpg and dirmngr are good.  Both programs should work
+fine for the simple case without any config file.  The skeleton config
+files were being copied at first use (when the defaults are fine).
+But when the user needs to fiddle with them (after they've become
+sophisticated users), they're likely out of date because gpg has been
+upgraded since then.  So they're used for documentation, but they're
+stale documentation, which is probably worse than a clean empty file.
+
+--
+
+GnuPG-bug-id: 3086
+Signed-off-by: Daniel Kahn Gillmor <dkg at fifthhorseman.net>
+---
+ build-aux/speedo/w32/inst.nsi |   2 -
+ doc/gpg.texi                  |   4 --
+ g10/Makefile.am               |   8 +--
+ g10/dirmngr-conf.skel         |  73 ----------------------
+ g10/openfile.c                | 102 -------------------------------
+ g10/options.skel              | 139 ------------------------------------------
+ 6 files changed, 1 insertion(+), 327 deletions(-)
+ delete mode 100644 g10/dirmngr-conf.skel
+ delete mode 100644 g10/options.skel
+
+diff --git a/build-aux/speedo/w32/inst.nsi b/build-aux/speedo/w32/inst.nsi
+index b4d6994..7716f7f 100644
+--- a/build-aux/speedo/w32/inst.nsi
++++ b/build-aux/speedo/w32/inst.nsi
+@@ -608,8 +608,6 @@ Section "GnuPG" SEC_gnupg
+       Rename /REBOOTOK scdaemon.exe.tmp scdaemon.exe
+ 
+   SetOutPath "$INSTDIR\share\gnupg"
+-  File "share/gnupg/gpg-conf.skel"
+-  File "share/gnupg/dirmngr-conf.skel"
+   File "share/gnupg/distsigkey.gpg"
+   File "share/gnupg/sks-keyservers.netCA.pem"
+ 
+diff --git a/doc/gpg.texi b/doc/gpg.texi
+index 37e1ff1..1fa5381 100644
+--- a/doc/gpg.texi
++++ b/doc/gpg.texi
+@@ -3477,10 +3477,6 @@ files; They all live in the current home directory (@pxref{option
+   You should backup all files in this directory and take care to keep
+   this backup closed away.
+ 
+-  @item @value{DATADIR}/options.skel
+-  @efindex options.skel
+-  The skeleton options file.
+-
+ @end table
+ 
+ Operation is further controlled by a few environment variables:
+diff --git a/g10/Makefile.am b/g10/Makefile.am
+index f1d2d17..142b2f3 100644
+--- a/g10/Makefile.am
++++ b/g10/Makefile.am
+@@ -18,7 +18,7 @@
+ 
+ ## Process this file with automake to produce Makefile.in
+ 
+-EXTRA_DIST = options.skel dirmngr-conf.skel distsigkey.gpg \
++EXTRA_DIST = distsigkey.gpg \
+ 	     ChangeLog-2011 gpg-w32info.rc \
+ 	     gpg.w32-manifest.in test.c t-keydb-keyring.kbx \
+ 	     t-keydb-get-keyblock.gpg t-stutter-data.asc
+@@ -238,18 +238,12 @@ install-exec-hook:
+ 
+ install-data-local:
+ 	$(mkinstalldirs) $(DESTDIR)$(pkgdatadir)
+-	$(INSTALL_DATA) $(srcdir)/options.skel \
+-				$(DESTDIR)$(pkgdatadir)/gpg-conf.skel
+-	$(INSTALL_DATA) $(srcdir)/dirmngr-conf.skel \
+-				$(DESTDIR)$(pkgdatadir)/dirmngr-conf.skel
+ 	$(INSTALL_DATA) $(srcdir)/distsigkey.gpg \
+ 				$(DESTDIR)$(pkgdatadir)/distsigkey.gpg
+ 
+ # NB: For uninstalling gpg and gpgv we use -local because there is
+ # no need for a specific order the targets need to be run.
+ uninstall-local:
+-	- at rm $(DESTDIR)$(pkgdatadir)/gpg-conf.skel
+-	- at rm $(DESTDIR)$(pkgdatadir)/dirmngr-conf.skel
+ 	- at rm $(DESTDIR)$(pkgdatadir)/distsigkey.gpg
+ 	- at files=`for p in $(gpg2_hack_uninst); do echo "$$p"; done | \
+ 	  sed -e 'h;s,^.*/,,;s/$(EXEEXT)$$//;$(transform)' \
+diff --git a/g10/dirmngr-conf.skel b/g10/dirmngr-conf.skel
+deleted file mode 100644
+index e2885e6..0000000
+--- a/g10/dirmngr-conf.skel
++++ /dev/null
+@@ -1,73 +0,0 @@
+-# dirmngr-conf.skel - Skeleton to create dirmngr.conf.
+-# (Note that the first three lines are not copied.)
+-#
+-# dirmngr.conf - Options for Dirmngr
+-# Written in 2015 by The GnuPG Project <https://gnupg.org>
+-#
+-# To the extent possible under law, the authors have dedicated all
+-# copyright and related and neighboring rights to this file to the
+-# public domain worldwide.  This file is distributed without any
+-# warranty.  You should have received a copy of the CC0 Public Domain
+-# Dedication along with this file. If not, see
+-# <http://creativecommons.org/publicdomain/zero/1.0/>.
+-#
+-#
+-# Unless you specify which option file to use (with the command line
+-# option "--options filename"), the file ~/.gnupg/dirmngr.conf is used
+-# by dirmngr.  The file can contain any long options which are valid
+-# for Dirmngr.  If the first non white space character of a line is a
+-# '#', the line is ignored.  Empty lines are also ignored.  See the
+-# dirmngr man page or the manual for a list of options.
+-#
+-
+-# --keyserver URI
+-#
+-# GPG can send and receive keys to and from a keyserver.  These
+-# servers can be HKP, Email, or LDAP (if GnuPG is built with LDAP
+-# support).
+-#
+-# Example HKP keyservers:
+-#      hkp://keys.gnupg.net
+-#
+-# Example HKP keyserver using a Tor OnionBalance service
+-#      hkp://jirk5u4osbsr34t5.onion
+-#
+-# Example HKPS keyservers (see --hkp-cacert below):
+-#       hkps://hkps.pool.sks-keyservers.net
+-#
+-# Example LDAP keyservers:
+-#      ldap://pgp.surfnet.nl:11370
+-#
+-# Regular URL syntax applies, and you can set an alternate port
+-# through the usual method:
+-#      hkp://keyserver.example.net:22742
+-#
+-# Note that most servers (with the notable exception of
+-# ldap://keyserver.pgp.com) synchronize changes with each other.  Note
+-# also that a single server name may actually point to multiple
+-# servers via DNS round-robin or service records.
+-#
+-# If exactly two keyservers are configured and only one is a Tor hidden
+-# service, Dirmngr selects the keyserver to use depending on whether
+-# Tor is locally running or not (on a per session base).  Example:
+-#
+-#  keyserver hkp://jirk5u4osbsr34t5.onion
+-#  keyserver hkps://hkps.pool.sks-keyservers.net
+-#
+-# If no keyserver is specified GnuPG uses
+-#  hkps://hkps.pool.sks-keyservers.net
+-
+-
+-# --hkp-cacert FILENAME
+-#
+-# For the "hkps" scheme (keyserver access over TLS), Dirmngr needs to
+-# know the root certificates for verification of the TLS certificates
+-# used for the connection.  Enter the full name of a file with the
+-# root certificates here.  If that file is in PEM format a ".pem"
+-# suffix is expected.  This option may be given multiple times to add
+-# more root certificates.  Tilde expansion is supported.
+-# This is not required when the default server
+-#   hkps://hkps.pool.sks-keyservers.net
+-# is used.
+-
+-#hkp-cacert /path/to/CA/sks-keyservers.netCA.pem
+diff --git a/g10/openfile.c b/g10/openfile.c
+index 2257107..a557a98 100644
+--- a/g10/openfile.c
++++ b/g10/openfile.c
+@@ -36,12 +36,6 @@
+ #include "../common/status.h"
+ #include "../common/i18n.h"
+ 
+-#ifdef USE_ONLY_8DOT3
+-#define SKELEXT ".skl"
+-#else
+-#define SKELEXT EXTSEP_S "skel"
+-#endif
+-
+ #ifdef HAVE_W32_SYSTEM
+ #define NAME_OF_DEV_NULL "nul"
+ #else
+@@ -373,93 +367,6 @@ open_sigfile (const char *sigfilename, progress_filter_context_t *pfx)
+ }
+ 
+ 
+-/****************
+- * Copy the option file skeleton for NAME to the given directory.
+- * Returns true if the new option file has any option.
+- */
+-static int
+-copy_options_file (const char *destdir, const char *name)
+-{
+-  const char *datadir = gnupg_datadir ();
+-  char *fname;
+-  FILE *src, *dst;
+-  int linefeeds=0;
+-  int c;
+-  mode_t oldmask;
+-  int esc = 0;
+-  int any_option = 0;
+-
+-  if (opt.dry_run)
+-    return 0;
+-
+-  fname = xstrconcat (datadir, DIRSEP_S, name, "-conf", SKELEXT, NULL);
+-  src = fopen (fname, "r");
+-  if (src && is_secured_file (fileno (src)))
+-    {
+-      fclose (src);
+-      src = NULL;
+-      gpg_err_set_errno (EPERM);
+-    }
+-  if (!src)
+-    {
+-      log_info (_("can't open '%s': %s\n"), fname, strerror(errno));
+-      xfree(fname);
+-      return 0;
+-    }
+-  xfree (fname);
+-  fname = xstrconcat (destdir, DIRSEP_S, name, EXTSEP_S, "conf", NULL);
+-
+-  oldmask = umask (077);
+-  if (is_secured_filename (fname))
+-    {
+-      dst = NULL;
+-      gpg_err_set_errno (EPERM);
+-    }
+-  else
+-    dst = fopen( fname, "w" );
+-  umask (oldmask);
+-
+-  if (!dst)
+-    {
+-      log_info (_("can't create '%s': %s\n"), fname, strerror(errno) );
+-      fclose (src);
+-      xfree (fname);
+-      return 0;
+-    }
+-
+-  while ((c = getc (src)) != EOF)
+-    {
+-      if (linefeeds < 3)
+-        {
+-          if (c == '\n')
+-            linefeeds++;
+-	}
+-      else
+-        {
+-          putc (c, dst);
+-          if (c== '\n')
+-            esc = 1;
+-          else if (esc == 1)
+-            {
+-              if (c == ' ' || c == '\t')
+-                ;
+-              else if (c == '#')
+-                esc = 2;
+-              else
+-                any_option = 1;
+-            }
+-        }
+-    }
+-
+-  fclose (dst);
+-  fclose (src);
+-
+-  log_info (_("new configuration file '%s' created\n"), fname);
+-  xfree (fname);
+-  return any_option;
+-}
+-
+-
+ void
+ try_make_homedir (const char *fname)
+ {
+@@ -489,15 +396,6 @@ try_make_homedir (const char *fname)
+                     fname, strerror(errno) );
+       else if (!opt.quiet )
+         log_info ( _("directory '%s' created\n"), fname );
+-
+-      /* Note that we also copy a dirmngr.conf file here.  This is
+-         because gpg is likely the first invoked tool and thus creates
+-         the directory.  */
+-      copy_options_file (fname, DIRMNGR_NAME);
+-      if (copy_options_file (fname, GPG_NAME))
+-        log_info (_("WARNING: options in '%s'"
+-                    " are not yet active during this run\n"),
+-                  fname);
+     }
+ }
+ 
+diff --git a/g10/options.skel b/g10/options.skel
+deleted file mode 100644
+index 87fc627..0000000
+--- a/g10/options.skel
++++ /dev/null
+@@ -1,139 +0,0 @@
+-# These first three lines are not copied to the gpg.conf file in
+-# the users home directory.
+-# $Id$
+-# Options for GnuPG
+-# Copyright 1998-2003, 2010 Free Software Foundation, Inc.
+-# Copyright 1998-2003, 2010 Werner Koch
+-#
+-# This file is free software; as a special exception the author gives
+-# unlimited permission to copy and/or distribute it, with or without
+-# modifications, as long as this notice is preserved.
+-#
+-# This file is distributed in the hope that it will be useful, but
+-# WITHOUT ANY WARRANTY, to the extent permitted by law; without even the
+-# implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+-#
+-# Unless you specify which option file to use (with the command line
+-# option "--options filename"), GnuPG uses the file ~/.gnupg/gpg.conf
+-# by default.
+-#
+-# An options file can contain any long options which are available in
+-# GnuPG. If the first non white space character of a line is a '#',
+-# this line is ignored.  Empty lines are also ignored.
+-#
+-# See the gpg man page for a list of options.
+-
+-
+-# If you have more than 1 secret key in your keyring, you may want to
+-# uncomment the following option and set your preferred keyid.
+-
+-#default-key 621CC013
+-
+-
+-# If you do not pass a recipient to gpg, it will ask for one.  Using
+-# this option you can encrypt to a default key.  Key validation will
+-# not be done in this case.  The second form uses the default key as
+-# default recipient.
+-
+-#default-recipient some-user-id
+-#default-recipient-self
+-
+-
+-# Group names may be defined like this:
+-#   group mynames = paige 0x12345678 joe patti
+-#
+-# Any time "mynames" is a recipient (-r or --recipient), it will be
+-# expanded to the names "paige", "joe", and "patti", and the key ID
+-# "0x12345678".  Note there is only one level of expansion - you
+-# cannot make an group that points to another group.  Note also that
+-# if there are spaces in the recipient name, this will appear as two
+-# recipients.  In these cases it is better to use the key ID.
+-
+-#group mynames = paige 0x12345678 joe patti
+-
+-
+-# GnuPG can automatically locate and retrieve keys as needed using
+-# this option.  This happens when encrypting to an email address (in
+-# the "user@@example.com" form) and there are no keys matching
+-# "user at example.com" in the local keyring.  This option takes any
+-# number mechanisms which are tried in the given order.  The default
+-# is "--auto-key-locate local" to search for keys only in the local
+-# key database.  Uncomment the next line to locate a missing key using
+-# two DNS based mechanisms.
+-
+-#auto-key-locate local,pka,dane
+-
+-
+-# Common options for keyserver functions:
+-# (Note that the --keyserver option has been moved to dirmngr.conf)
+-#
+-# include-disabled = when searching, include keys marked as "disabled"
+-#                    on the keyserver (not all keyservers support this).
+-#
+-# no-include-revoked = when searching, do not include keys marked as
+-#                      "revoked" on the keyserver.
+-#
+-# verbose = show more information as the keys are fetched.
+-#           Can be used more than once to increase the amount
+-#           of information shown.
+-#
+-# auto-key-retrieve = automatically fetch keys as needed from the keyserver
+-#                     when verifying signatures or when importing keys that
+-#                     have been revoked by a revocation key that is not
+-#                     present on the keyring.
+-#
+-# no-include-attributes = do not include attribute IDs (aka "photo IDs")
+-#                         when sending keys to the keyserver.
+-
+-#keyserver-options auto-key-retrieve
+-
+-
+-# Uncomment this line to display photo user IDs in key listings and
+-# when a signature from a key with a photo is verified.
+-
+-#show-photos
+-
+-
+-# Use this program to display photo user IDs
+-#
+-# %i is expanded to a temporary file that contains the photo.
+-# %I is the same as %i, but the file isn't deleted afterwards by GnuPG.
+-# %k is expanded to the key ID of the key.
+-# %K is expanded to the long OpenPGP key ID of the key.
+-# %t is expanded to the extension of the image (e.g. "jpg").
+-# %T is expanded to the MIME type of the image (e.g. "image/jpeg").
+-# %f is expanded to the fingerprint of the key.
+-# %% is %, of course.
+-#
+-# If %i or %I are not present, then the photo is supplied to the
+-# viewer on standard input.  If your platform supports it, standard
+-# input is the best way to do this as it avoids the time and effort in
+-# generating and then cleaning up a secure temp file.
+-#
+-# The default program is "xloadimage -fork -quiet -title 'KeyID 0x%k' stdin"
+-# On Mac OS X and Windows, the default is to use your regular JPEG image
+-# viewer.
+-#
+-# Some other viewers:
+-# photo-viewer "qiv %i"
+-# photo-viewer "ee %i"
+-# photo-viewer "display -title 'KeyID 0x%k'"
+-#
+-# This one saves a copy of the photo ID in your home directory:
+-# photo-viewer "cat > ~/photoid-for-key-%k.%t"
+-#
+-# Use your MIME handler to view photos:
+-# photo-viewer "metamail -q -d -b -c %T -s 'KeyID 0x%k' -f GnuPG"
+-
+-
+-# Because some mailers change lines starting with "From " to ">From "
+-# it is good to handle such lines in a special way when creating
+-# cleartext signatures; all other PGP versions do it this way too.
+-# To enable full OpenPGP compliance you may want to use this option.
+-
+-#no-escape-from-lines
+-
+-
+-# Uncomment the following option to get rid of the copyright notice
+-
+-#no-greeting

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-gnupg/gnupg2.git



More information about the Pkg-gnupg-commit mailing list