[Pkg-gpe-maintainers] Bug#643399: gpe-shield: FTBFS: interface.c:155:7: error: format not a string literal and no format arguments [-Werror=format-security]

[Didier Raboud]

Source: gpe-shield
Version: 0.31-4
Severity: serious
Tags: wheezy sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> cc -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall  -MD -Wall -pthread -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/cairo -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -pthread -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/cairo -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -Os -fomit-frame-pointer -DVERSION=\"0.31\" -DPREFIX=\"/usr\" -D_GNU_SOURCE -DPACKAGE=\"gpe-shield\" -DPACKAGE_LOCALE_DIR=\"/usr/share/locale\" -D_GNU_SOURCE -DPACKAGE=\"gpe-shield\" -DPREFIX=\"/usr\" -DPACKAGE_LOCALE_DIR=\"/usr/share/locale\" -c interface.c -o interface.o
> interface.c: In function 'show_message':
> interface.c:155:7: error: format not a string literal and no format arguments [-Werror=format-security]
> interface.c: In function 'update_tree':
> interface.c:472:2: warning: #warning improve this [-Wcpp]
> interface.c: In function 'do_message_dlg':
> interface.c:535:7: error: format not a string literal and no format arguments [-Werror=format-security]
> cc1: some warnings being treated as errors
> 
> make[1]: *** [interface.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2011/09/23/gpe-shield_0.31-4_lsid64.buildlog

This happened because since dpkg 1.16.0 [0], hardening flags are enabled 
under various conditions.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.