[Pkg-gpe-maintainers] Bug#665569: libgpewidget: Including individual glib headers no longer supported

[Michael Biebl]

On 24.03.2012 21:39, Neil Williams wrote:
> tag 665569 + pending
> quit
> 
> On Sat, 24 Mar 2012 20:07:57 +0100
> biebl at debian.org wrote:
> 
>> including invidiual glib headers has been deprecated for several years.
> 
> It may be helpful with future bug reports for this issue to clarify
> things slightly as to the status of include lines like:
> 
> #include <glib-object.h>
> 
> (I thought this was going to be a bigger issue than it now seems as
> there are quite a lot of uses of glib-gobject.h in GPE code. It was
> only when I started delving into the links that the more limited impact
> became clearer.)
> 
> The quoted build log fails with:
> 
> libgpewidget/gpehelp.c:#include <glib/gkeyfile.h>

I meantioned #include <glib/foo.h> as an example, so I thought this was
clear. But apparently not :-)

> This is a much simpler issue to fix (and I've since checked that this
> is the single incidence of a glib/ inclusion other than gprintf.h
> specified below).

Yeah, my script produces the following patch

Index: libgpewidget-0.117/gpehelp.c
===================================================================
--- libgpewidget-0.117.orig/gpehelp.c	2006-10-12 12:20:33.000000000 +0200
+++ libgpewidget-0.117/gpehelp.c	2012-03-24 21:44:41.038318713 +0100
@@ -33,7 +33,6 @@
 #include <gdk-pixbuf/gdk-pixbuf.h>
 #include <gdk/gdk.h>
 #include <glib.h>
-#include <glib/gkeyfile.h>


 /* helper function definitions*/


>> With the notable exception of:
>>  glib/gi18n.h
>>  glib/gi18n-lib.h
>>  glib/gprintf.h
>>  glib/gstdio.h
>> Those header files are still meant to be included separately.
>>
>> Please update libgpewidget at your earliest convenience, so once we move
>> the glib version from experimental to unstable, your package will remain
>> buildable.
> 
> Turns out that in this case, the individual header was not necessary
> for the build - the preceding line included glib.h

Yeah, looks correct

> Any idea when the relevant version of glib will arrive in unstable? Are
> we talking days or weeks? (Presumably before the Wheezy freeze.)

As soon as possible, hopefully within the next two weeks, I'd say.
It depends a bit on how fast the packages are fixed.

> Patch committed to pkg-gpe SVN and I'll test with a chroot build using
> glib from experimental before uploading.
> 
> Hopefully I'll have time to look at some of the Debian QA packages
> affected too:
> Debian QA Group <packages at qa.debian.org>
>    glabels
>    gnunet-gtk
>    israndom
>    maximus
> 
> Thanks for doing the test builds in advance of this change.

And thanks to you for the quick response and for having a look at the QA
packages!

Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-gpe-maintainers/attachments/20120324/fbf0d331/attachment.pgp>