Bug#337804: marked as done (Doesn't use CPU runtime detection in libpostproc)

Sun Nov 6 19:34:13 UTC 2005

Your message dated Sun, 06 Nov 2005 10:32:08 -0800
with message-id <E1EYpJI-00023V-00 at spohr.debian.org>
and subject line Bug#337804: fixed in gst-ffmpeg 0.8.7-3
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 6 Nov 2005 16:33:25 +0000
>From slomo at slomosnail.de Sun Nov 06 08:33:25 2005
Return-path: <slomo at slomosnail.de>
Received: from slomosnail.de (mail.slomosnail.de) [83.151.31.59] 
	by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
	id 1EYnSP-0007lU-00; Sun, 06 Nov 2005 08:33:25 -0800
Received: from wotan.yggdrasil.168.192.in-addr.arpa (p5487EB70.dip.t-dialin.net [84.135.235.112])
	by mail.slomosnail.de (Postfix) with ESMTP id 8C26E42A23
	for <submit at bugs.debian.org>; Sun,  6 Nov 2005 17:30:35 +0100 (CET)
Subject: Doesn't use CPU runtime detection in libpostproc
From: Sebastian =?ISO-8859-1?Q?Dr=F6ge?= <slomo at slomosnail.de>
To: submit at bugs.debian.org
Content-Type: text/plain
Date: Sun, 06 Nov 2005 17:32:07 +0100
Message-Id: <1131294728.20965.21.camel at localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.5.1 
Content-Transfer-Encoding: 7bit
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02

Package: gst-ffmpeg
Version: 0.8.7-2
Severity: important

Hi,
currently gst-ffmpeg is compiled without CPU runtime detection and uses
for example altivec on all powerpc cpus, whether there is altivec or
not.

I would add -DRUNTIME_CPUDETECT to the CFLAGS for every arch to fix
this. Works and compiles fine here on a G4

btw, the -maltivec should be fine, no matter what I've told on IRC. It
only enables the usage altivec instructions, nothing else...

Below is the IRC log copied where we were talking about this

<slomo_> lool: btw, you're enabling altivec on ppc... doesn't this
prevent gst-ffmpeg from working on g3 or other non-altivec ppc?
<lool> slomo_: I think it's detected at runtime too
<slomo_> lool: hm, sounds like this... "fixes altivec detection so it
runs on G3 CPUs, also"
<lool> slomo_: pleas rephrase your question, I don't understand it
--> JHM (ray at node-072-048.dsl.active24.nl) has joined #gnome-debian
<slomo_> currently gst-ffmpeg is compiled with altivec support on ppc...
and you add -maltivec to the CFLAGS for ppc... but afaik a ffmpeg
doesn't have runtime detection code for this and -maltivec will make the
binaries incompatible with non-altivec cpus...
<slomo_> but i'm not sure... i'll take a further look
<slomo_> lool: yes, seems like it for -maltivec...
http://gcc.gnu.org/onlinedocs/gcc-4.0.2/gcc/RS_002f6000-and-PowerPC-Options.html#index-maltivec-1293
<slomo_> lool: also the configure test in the ffmpeg source tree will
fail when running on a g3 which will result in disabled altivec support
<lool> slomo_: using -maltivec shouldn't be enough to generate altivec
code
<lool> slomo_: AFAIK, it only allows usage of altivec
<lool> slomo_: debian packages are built on altivec machines
<lool> slomo_: and the generated ffmpeg code should have altivec code,
with a runtime check to use it, or to use the non-altivec alternative
<slomo_> lool: ok if that's the case it's fine... i'll take a deeper
look at the ffmpeg sources... 
<lool> slomo_: let me know if one of the statements I just made aren't
true, that would be an important or serious bug
<slomo_> lool: sure... i'm looking at this because someone joined a
ubuntu channel, said that it doesn't work on his G3 because of illegal
instruction and leaved instantly ;)
<lool> it might not build, but it should work
<slomo_> hm, from my understanding libavcodec should be fine but
libpostproc isn't... it only uses runtime cpu detection when
RUNTIME_CPUDETECT is defined
<slomo_> and this isn't defined by any configure switch or something
<slomo_> libpostproc uses only altivec (or MMX, SSE, whatever) code when
this is not defined and provides no fallback when it isn't there
<lool> that's bad news, what ffmpeg source did you look at?
gst-ffmpeg's?
<slomo_> yes
<slomo_> for example look at postprocess.c... there's a big #ifdef block
with RUNTIME_CPUDETECT
<slomo_> but RUNTIME_CPUDETECT isn't defined somewhere
<lool> slomo_: could you please file a bug with severity important
against gst-ffmpeg so that I can check later?

---------------------------------------
Received: (at 337804-close) by bugs.debian.org; 6 Nov 2005 18:36:39 +0000
>From katie at spohr.debian.org Sun Nov 06 10:36:37 2005
Return-path: <katie at spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
	id 1EYpJI-00023V-00; Sun, 06 Nov 2005 10:32:08 -0800
From: Loic Minier <lool at dooz.org>
To: 337804-close at bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#337804: fixed in gst-ffmpeg 0.8.7-3
Message-Id: <E1EYpJI-00023V-00 at spohr.debian.org>
Sender: Archive Administrator <katie at spohr.debian.org>
Date: Sun, 06 Nov 2005 10:32:08 -0800
Delivered-To: 337804-close at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02

Source: gst-ffmpeg
Source-Version: 0.8.7-3

We believe that the bug you reported is fixed in the latest version of
gst-ffmpeg, which is due to be installed in the Debian FTP archive:

gst-ffmpeg_0.8.7-3.diff.gz
  to pool/main/g/gst-ffmpeg/gst-ffmpeg_0.8.7-3.diff.gz
gst-ffmpeg_0.8.7-3.dsc
  to pool/main/g/gst-ffmpeg/gst-ffmpeg_0.8.7-3.dsc
gstreamer0.8-ffmpeg_0.8.7-3_i386.deb
  to pool/main/g/gst-ffmpeg/gstreamer0.8-ffmpeg_0.8.7-3_i386.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 337804 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Loic Minier <lool at dooz.org> (supplier of updated gst-ffmpeg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun,  6 Nov 2005 19:03:38 +0100
Source: gst-ffmpeg
Binary: gstreamer0.8-ffmpeg
Architecture: source i386
Version: 0.8.7-3
Distribution: unstable
Urgency: low
Maintainer: Maintainers of GStreamer packages <pkg-gstreamer-maintainers at lists.alioth.debian.org>
Changed-By: Loic Minier <lool at dooz.org>
Description: 
 gstreamer0.8-ffmpeg - FFmpeg plugin for GStreamer
Closes: 337804
Changes: 
 gst-ffmpeg (0.8.7-3) unstable; urgency=low
 .
   * Use -DRUNTIME_CPUDETECT to detect the correct per-CPU optimized function
     at runtime. (Closes: #337804)
Files: 
 a9276c39c2079d1987249cd4fea51f3d 864 libs optional gst-ffmpeg_0.8.7-3.dsc
 7873238031ade67d6b6e1809de2a079e 3480 libs optional gst-ffmpeg_0.8.7-3.diff.gz
 b28627cefac2d44da4384d1be09990ae 2030412 libs optional gstreamer0.8-ffmpeg_0.8.7-3_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDbkik4VUX8isJIMARAtr4AJ9mekpL1Rj37E2lnT1Jb4C3nBoPMQCgsM9e
Px22bcWPLWf6mvEvQgnC1bk=
=KjTm
-----END PGP SIGNATURE-----