Bug#395925: gst-plugins0.8: Messes with .diff.gz and no longer rebuilds

[Helge Kreutzmann]

Package: gst-plugins0.8
Version: 0.8.12-5
Severity: important

All this in an i386 up to date changeroot, but I doubt it is
architecture specific (can try x86_64 and ppc testing, if needed).

1. Download gst-plugins0.8 (orig.tar.gz and diff.gz). 
2. Record md5sums:

aab4331c2b134ad935cfdefa380525d4  gst-plugins0.8_0.8.12-5.diff.gz
4a6c5f5384d148c752311b32c5f9a122  gstreamer0.8_0.8.12.orig.tar.gz

3. Unpack gstreamer0.8_0.8.12.orig.tar.gz, apply diff.gz and run
   debuild. All debs build fine (of course, signing fails). 

4. Record md5sums:
5cad60c0f5b6ae34f92d333b24c4b028  gst-plugins0.8_0.8.12-5.diff.gz
4a6c5f5384d148c752311b32c5f9a122  gstreamer0.8_0.8.12.orig.tar.gz
   As you can see, the diff.gz has a different md5sum. 

5. Run debuild again.
   Now the build fails with:
make[1]: Leaving directory `/debuild/NEU-G/gst-plugins-0.8.12'
patches: debian/patches/20_gst-doc-m4.patch debian/patches/30_gstcacasink-header-include.patch debian/patches/50_ladspa-quiet.patch debian/patches/51_wavpack-big-endian.patch debian/patches/70_relibtoolize.patch
Trying patch debian/patches/20_gst-doc-m4.patch at level 1...success.
Trying patch debian/patches/30_gstcacasink-header-include.patch at level 1...success.
Trying patch debian/patches/50_ladspa-quiet.patch at level 1...0...2...failure.
make: *** [debian/stamp-patched] Fehler 1
debuild: fatal error at line 1224:
debian/rules build failed

6. Record md5sums:
a83dd74217efd1be22630a4bde41b8e5  gst-plugins0.8_0.8.12-5.diff.gz
4a6c5f5384d148c752311b32c5f9a122  gstreamer0.8_0.8.12.orig.tar.gz
   Again, a new md5sum for the diff.gz!

7. Ok, just to check:
   make -f debian/rules clean
   No problems reported

8. Run debuild again:
make[1]: Leaving directory `/debuild/NEU-G/gst-plugins-0.8.12'
patches: debian/patches/20_gst-doc-m4.patch debian/patches/30_gstcacasink-header-include.patch debian/patches/50_ladspa-quiet.patch debian/patches/51_wavpack-big-endian.patch debian/patches/70_relibtoolize.patch
Trying patch debian/patches/20_gst-doc-m4.patch at level 1...success.
Trying patch debian/patches/30_gstcacasink-header-include.patch at level 1...success.
Trying patch debian/patches/50_ladspa-quiet.patch at level 1...0...2...failure.
make: *** [debian/stamp-patched] Fehler 1
debuild: fatal error at line 1224:
debian/rules build failed

9. Run md5sum again:
cfc46c7b3ebc9f8f27af65f15661e37d  gst-plugins0.8_0.8.12-5.diff.gz
4a6c5f5384d148c752311b32c5f9a122  gstreamer0.8_0.8.12.orig.tar.gz
   Again a new md5sum

10. Re-Unpack the source (in a fresh directory, i.e. moving the
    previous attempts out of the way), use the diff.gz from step 4 to
    patch the source and run debuild:

    Everything is fine

11. Re-Unpack the source (in a fresh directory, i.e. moving the
    previous attempts out of the way), use the diff.gz from step 6 to
    patch the source and run debuild:

make[1]: Leaving directory `/debuild/NEU-G/gst-plugins-0.8.12'
patches: debian/patches/20_gst-doc-m4.patch debian/patches/30_gstcacasink-header-include.patch debian/patches/50_ladspa-quiet.patch debian/patches/51_wavpack-big-endian.patch debian/patches/70_relibtoolize.patch
Trying patch debian/patches/20_gst-doc-m4.patch at level 1...success.
Trying patch debian/patches/30_gstcacasink-header-include.patch at level 1...success.
Trying patch debian/patches/50_ladspa-quiet.patch at level 1...0...2...failure.
make: *** [debian/stamp-patched] Fehler 1
debuild: fatal error at line 1224:
debian/rules build failed

12. Run a diff between the original .diff.gz and the one from step 6 
    shows:
0a1,14
> --- gst-plugins0.8-0.8.12.orig/ext/ladspa/gstladspa.c
> +++ gst-plugins0.8-0.8.12/ext/ladspa/gstladspa.c
> @@ -514,7 +514,10 @@
>      /* for example, a plugin with only control inputs and output -- just ignore
>       * it for now */
>    } else {
> -    g_warning ("%d sink pads, %d src pads not yet supported", sinkcount,
> +    /* Changed from g_warning to DEBUG due to gst-compprep printing this for
> +     * certain ladspa plugins such as SinCos
> +     */
> +    GST_DEBUG_OBJECT (ladspa, "%d sink pads, %d src pads not yet supported",
sinkcount,
>          srccount);
>    }
>

Why am I reporting this? I try to debug #385322 and run step 1, 3 (to
check if everything works out of the box), set
export DEB_BUILD_OPTIONS="nostrip"
and run step 5. Ok, I thought, run step 11 and 12. There I was goofed,
because I had (in that attempt) kept the original .diff.gz (which I
did for reporting this bug). 

So in essence, your package FTBS on the second run, which can only be
rectified by re-retrieving the .diff.gz.

I know that sometimes a build is not idempotent (which IMHO it
should), but then the *diff.gz should not be changed!


-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17.7-grsec-cz01
Locale: LANG=de_DE at euro, LC_CTYPE=de_DE at euro (charmap=ISO-8859-15)
-- 
      Dr. Helge Kreutzmann                     debian at helgefjell.de
           Dipl.-Phys.                   http://www.helgefjell.de/debian.php
        64bit GNU powered                     gpg signed mail preferred
           Help keep free software "libre": http://www.ffii.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-gstreamer-maintainers/attachments/20061028/6778338e/attachment.pgp