Bug#433213: FTBFS on arm, armel, unportable identified "$" used.

[Riku Voipio]

Package: schroedinger
Version: 0.6.1-1
Severity: normal

schroedinger testsuite uses "$" as identifier in selected places:

  int $;

    for($=0;$<sizeof(generators)/sizeof(generators[0]);$++){

Please don't. ISO C [1] does not list it as one of the allowed
characters for identifier. It *does* allow implementions to use
other characters as well, but that makes the code non-portable.

[1] See page 51 on: http://www.open-std.org/JTC1/SC22/WG14/www/docs/n1124.pdf

-build-log-

cc -DHAVE_CONFIG_H -I. -I..    -Wall -I.. -I/usr/include/liboil-0.3   -g
-Wall -O2 -c -o wavelet-wavelet.o `test
+-f 'wavelet.c' || echo './'`wavelet.c
wavelet.c: In function 'local_test':
wavelet.c:111: error: stray '$' in program
wavelet.c:111: warning: useless type name in empty declaration
wavelet.c:113: error: stray '$' in program
wavelet.c:113: error: expected expression before '=' token
wavelet.c:113: error: stray '$' in program
wavelet.c:113: error: stray '$' in program
wavelet.c:113: error: expected expression before ')' token
wavelet.c:114: error: stray '$' in program
wavelet.c:115: error: stray '$' in program
wavelet.c:115: error: expected expression before ']' token
wavelet.c: In function 'random_test':
wavelet.c:139: error: stray '$' in program
wavelet.c:139: warning: useless type name in empty declaration
wavelet.c:145: error: stray '$' in program
wavelet.c:145: error: expected expression before '=' token
wavelet.c:145: error: stray '$' in program
wavelet.c:145: error: stray '$' in program
wavelet.c:145: error: expected expression before ')' token
wavelet.c:178: error: stray '$' in program
wavelet.c:178: error: expected expression before '=' token
wavelet.c:178: error: stray '$' in program
wavelet.c:178: error: stray '$' in program
wavelet.c:178: error: expected expression before ')' token
make[4]: *** [wavelet-wavelet.o] Error 1

-- 
"rm -rf" only sounds scary if you don't have backups