Bug#683919: Can't use the final version of opus

[Ron]

Hi Sjoerd,

Could you please clarify a little exactly what you're seeing here:

> The Opus codec has been finalized recently, unfortunately the version of the
> opus plugin in Debian wasn't updated yet with the latest changes (although it
> has been fixed upstream). Using the final version of opus with the gstreamer
> opus plugin in debian makes Gstreamer crash or fail. This means that as it
> stands the opus plugin as shipped by gstreamer is useless to all user and
> should either be removed or fixed.

Because if you're talking about what I _think_ you're talking about, then
the problem isn't with a "final version of opus", since opus shouldn't have
changed at all over that time.

There was a final revision to the Ogg mapping, but the only substantive
change there was the version being bumped from 0 to 1.  Everything else
was clarification of corner case handling.

There is however also a bug in the early gst code, that isn't related to
anything about the spec changing, it's simply reading (and possibly writing)
the gain field from the wrong offset in the Ogg header.

While I agree this is important to fix for the release, so that we don't
have gst creating invalid files, the real effect of it should mostly be
imperceptible, and it almost certainly shouldn't cause a "crash".


So if you are seeing a crash, then maybe what you are seeing is something
different, and we'd be keen to know what that is.  If gst can be crashed
by the bug above, that's almost certainly a separate bug in gst that also
should be fixed (since anyone could write a file that would crash it in
that case even if this bug was fixed).

If you can crash it, an example of how to reproduce that would probably
be really helpful.

 Cheers,
 Ron