Bug#681204: snappy-player: SIGSEGV if recently viewed URIs list is empty

[George Danchev]

Source: snappy-player
Version: 0.2-1
Severity: normal
Tags: upstream patch

Dear Maintainer,

$ cat ~/.config/snappy/history 
$

$ snappy -r
These are the recently viewed URIs: 

Segmentation fault

$ rm -rf .config/snappy/
george at sid:~$ snappy -r
These are the recently viewed URIs: 

Segmentation fault


george at sid:/tmp/snappy-player-0.2/src$ gdb ./snappy 
GNU gdb (GDB) 7.4.1-debian
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show
copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /tmp/snappy-player-0.2/src/snappy...done.
(gdb) run -r 
Starting program: /tmp/snappy-player-0.2/src/snappy -r
[Thread debugging using libthread_db enabled]
Using host libthread_db library
"/lib/x86_64-linux-gnu/libthread_db.so.1".
These are the recently viewed URIs: 


Program received signal SIGSEGV, Segmentation fault.
process_args (argc=1, argv=0x7fffffffe3f8,
file_list=file_list at entry=0x7fffffffe2a0, 
    fullscreen=fullscreen at entry=0x7fffffffe2d8,
secret=secret at entry=0x7fffffffe2dc, context=context at entry=0x6108b0)
    at snappy.c:96
    96          for (c = 0; recent[c] != NULL; c++) {
    (gdb) list 
    91
    92          g_print ("These are the recently viewed URIs: \n\n");
    93
    94          recent = get_recently_viewed ();
    95
    96          for (c = 0; recent[c] != NULL; c++) {
    97            if (c < 9)
    98              g_print ("0%d: %s \n", c + 1, recent[c]);
    99            else
    100             g_print ("%d: %s \n", c + 1, recent[c]);
    (gdb) p recent 
    $1 = (gchar **) 0x0
    (gdb)


The attached patch fixes this for me. Please fix the diff headers
when BTS bug number entry is returned (add to series as well).


-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
-------------- next part --------------
A non-text attachment was scrubbed...
Name: recently-viewed-uris-empty
Type: text/x-diff
Size: 1712 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-gstreamer-maintainers/attachments/20120711/5f7c9a5f/attachment.diff>