Bug#726920: gst-plugins-good0.10: FTBFS with linux-headers-3.10-3

Fri Nov 22 20:46:42 UTC 2013

tags 726920 confirmed pending
tags 702366 confirmed pending
thanks

Hi John,

On 10/20/2013 05:43 PM, John David Anglin wrote:
> Source: gst-plugins-good0.10
> Version: 0.10.31-3+nmu1
> Severity: serious
> Tags: patch
> Justification: fails to build from source (but built successfully in the past)
> 
> There are now two issues:
> 
> In file included from /usr/include/gstreamer-0.10/gst/gst.h:49:0,
>                  from /usr/include/gstreamer-0.10/gst/video/video.h:24,
>                  from gstv4l2bufferpool.c:33:
> gstv4l2bufferpool.c: In function 'gst_v4l2_buffer_new':
> gstv4l2bufferpool.c:184:66: error: 'struct v4l2_buffer' has no member named 'input'
>    GST_LOG_OBJECT (pool->v4l2elem, "  input:     %u", ret->vbuffer.input);
>                                                                   ^
> It appears from head that the member input has been removed.
> 
> v4l2_calls.c: In function 'gst_v4l2_fill_lists':
> v4l2_calls.c:58:26: error: 'V4L2_CID_HCENTER_DEPRECATED' undeclared (first use in this function)
>  #define V4L2_CID_HCENTER V4L2_CID_HCENTER_DEPRECATED
>                           ^
> v4l2_calls.c:297:12: note: in expansion of macro 'V4L2_CID_HCENTER'
>        case V4L2_CID_HCENTER:
>             ^
> v4l2_calls.c:58:26: note: each undeclared identifier is reported only once for each function it appears in
>  #define V4L2_CID_HCENTER V4L2_CID_HCENTER_DEPRECATED
>                           ^
> v4l2_calls.c:297:12: note: in expansion of macro 'V4L2_CID_HCENTER'
>        case V4L2_CID_HCENTER:
>             ^
> v4l2_calls.c:61:26: error: 'V4L2_CID_VCENTER_DEPRECATED' undeclared (first use in this function)
>  #define V4L2_CID_VCENTER V4L2_CID_VCENTER_DEPRECATED
>                           ^
> v4l2_calls.c:298:12: note: in expansion of macro 'V4L2_CID_VCENTER'
>        case V4L2_CID_VCENTER:
>             ^
> make[4]: *** [libgstvideo4linux2_la-v4l2_calls.lo] Error 1
> 
> These ioctls are now removed.
> 
> Two patches to work around problem are attached.
Thank you for the patches.

I'm uploading the fixed version to DELAYED/5 with the attached patch.

Cheers,
Balint	
-------------- next part --------------
diff -Nru gst-plugins-good0.10-0.10.31/debian/changelog gst-plugins-good0.10-0.10.31/debian/changelog

--- gst-plugins-good0.10-0.10.31/debian/changelog	2012-11-13 03:58:30.000000000 +0100
+++ gst-plugins-good0.10-0.10.31/debian/changelog	2013-11-22 21:20:30.000000000 +0100
@@ -1,3 +1,13 @@
+gst-plugins-good0.10 (0.10.31-3+nmu2) UNRELEASED; urgency=low
+
+  [Balint Reczey]
+  * Non-maintainer upload.
+
+  [John David Anglin]
+  * Fix FTBFS with Linux 3.10 (Closes: #726920, #702366)
+
+ -- Balint Reczey <balint at balintreczey.hu>  Fri, 22 Nov 2013 21:17:43 +0100
+
 gst-plugins-good0.10 (0.10.31-3+nmu1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru gst-plugins-good0.10-0.10.31/debian/patches/01_v4l2_calls.patch gst-plugins-good0.10-0.10.31/debian/patches/01_v4l2_calls.patch
--- gst-plugins-good0.10-0.10.31/debian/patches/01_v4l2_calls.patch	1970-01-01 01:00:00.000000000 +0100
+++ gst-plugins-good0.10-0.10.31/debian/patches/01_v4l2_calls.patch	2013-11-22 21:22:40.000000000 +0100
@@ -0,0 +1,26 @@
+--- ./sys/v4l2/v4l2_calls.c.save	2012-02-17 05:48:47.000000000 -0500
++++ ./sys/v4l2/v4l2_calls.c	2013-10-19 22:47:51.628821842 -0400
+@@ -53,14 +53,6 @@
+ 
+ #include "gst/gst-i18n-plugin.h"
+ 
+-/* Those are ioctl calls */
+-#ifndef V4L2_CID_HCENTER
+-#define V4L2_CID_HCENTER V4L2_CID_HCENTER_DEPRECATED
+-#endif
+-#ifndef V4L2_CID_VCENTER
+-#define V4L2_CID_VCENTER V4L2_CID_VCENTER_DEPRECATED
+-#endif
+-
+ GST_DEBUG_CATEGORY_EXTERN (v4l2_debug);
+ #define GST_CAT_DEFAULT v4l2_debug
+ 
+@@ -294,8 +286,6 @@
+         break;
+       case V4L2_CID_HFLIP:
+       case V4L2_CID_VFLIP:
+-      case V4L2_CID_HCENTER:
+-      case V4L2_CID_VCENTER:
+ #ifdef V4L2_CID_PAN_RESET
+       case V4L2_CID_PAN_RESET:
+ #endif
diff -Nru gst-plugins-good0.10-0.10.31/debian/patches/02_gstv4l2bufferpool.patch gst-plugins-good0.10-0.10.31/debian/patches/02_gstv4l2bufferpool.patch
--- gst-plugins-good0.10-0.10.31/debian/patches/02_gstv4l2bufferpool.patch	1970-01-01 01:00:00.000000000 +0100
+++ gst-plugins-good0.10-0.10.31/debian/patches/02_gstv4l2bufferpool.patch	2013-11-22 21:23:28.000000000 +0100
@@ -0,0 +1,11 @@
+--- ./sys/v4l2/gstv4l2bufferpool.c.save	2013-10-19 22:37:44.015077780 -0400
++++ ./sys/v4l2/gstv4l2bufferpool.c	2013-10-19 22:38:06.651290549 -0400
+@@ -181,7 +181,7 @@
+     GST_LOG_OBJECT (pool->v4l2elem, "  MMAP offset:  %u",
+         ret->vbuffer.m.offset);
+   GST_LOG_OBJECT (pool->v4l2elem, "  length:    %u", ret->vbuffer.length);
+-  GST_LOG_OBJECT (pool->v4l2elem, "  input:     %u", ret->vbuffer.input);
++  /* GST_LOG_OBJECT (pool->v4l2elem, "  input:     %u", ret->vbuffer.input); */
+ 
+   data = (guint8 *) v4l2_mmap (0, ret->vbuffer.length,
+       PROT_READ | PROT_WRITE, MAP_SHARED, pool->video_fd,
diff -Nru gst-plugins-good0.10-0.10.31/debian/patches/series gst-plugins-good0.10-0.10.31/debian/patches/series
--- gst-plugins-good0.10-0.10.31/debian/patches/series	2012-05-22 10:12:55.000000000 +0200
+++ gst-plugins-good0.10-0.10.31/debian/patches/series	2013-11-22 21:23:59.000000000 +0100
@@ -1,2 +1,4 @@
 0001-pulsesrc-Listen-to-source-output-events-not-sink-inp.patch
+01_v4l2_calls.patch
+02_gstv4l2bufferpool.patch
 99_ltmain_as-needed.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 897 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-gstreamer-maintainers/attachments/20131122/2d41d574/attachment.sig>
