Bug#743055: FTBFS on kfreebsd-*: missing -lm

[Steven Chamberlain]

Package: gst-buzztard
Version: 0.6.0-1
Severity: serious
Tags: patch
User: debian-bsd at lists.debian.org
Usertags: kfreebsd

Hi,

gst-buzztard currently FTBFS on kfreebsd due to:

| /bin/bash ../libtool  --tag=CC   --mode=link gcc -I. -I.. -DG_LOG_DOMAIN=\"gst-buzztard-check\" -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-kfreebsd-gnu/glib-2.0/include -I/usr/include/gstre
| amer-0.10 -I/usr/include/libxml2    -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall  -Wl,-z,relro -o gst_buzztard gst_buzztard-m-gst-buzztard.o gst_buzztar
| d-s-gst-note2frequency.o gst_buzztard-e-gst-note2frequency.o gst_buzztard-t-gst-note2frequency.o ../libgstbuzztard/libgstbuzztard.la -pthread -Wl,--export-dynamic -lgstbase-0.10 -lgstcontroller-0.1
| 0 -lgstreamer-0.10 -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lxml2 -lglib-2.0   -lcheck 
| libtool: link: gcc -I. -I.. -DG_LOG_DOMAIN=\"gst-buzztard-check\" -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-kfreebsd-gnu/glib-2.0/include -I/usr/include/gstreamer-0.10 -I/usr/include/libxm
| l2 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -Wl,-z -Wl,relro -o .libs/gst_buzztard gst_buzztard-m-gst-buzztard.o gst_buzztard-s-gst-note2frequency.o
|  gst_buzztard-e-gst-note2frequency.o gst_buzztard-t-gst-note2frequency.o -pthread -Wl,--export-dynamic  ../libgstbuzztard/.libs/libgstbuzztard.so /usr/lib/x86_64-kfreebsd-gnu/libgstbase-0.10.so /us
| r/lib/x86_64-kfreebsd-gnu/libgstcontroller-0.10.so /usr/lib/x86_64-kfreebsd-gnu/libgstreamer-0.10.so -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lxml2 -lglib-2.0 -lcheck -pthread
| /usr/bin/ld.bfd.real: /usr/lib/gcc/x86_64-kfreebsd-gnu/4.8/../../../x86_64-kfreebsd-gnu/libcheck.a(check.o): undefined reference to symbol 'floor@@GLIBC_2.3'
| //lib/x86_64-kfreebsd-gnu/libm.so.1: error adding symbols: DSO missing from command line
| collect2: error: ld returned 1 exit status
| make[3]: *** [gst_buzztard] Error 1
| make[3]: Leaving directory `/home/steven/gst-buzztard-0.6.0/tests'
| make[2]: *** [all-recursive] Error 1
| make[2]: Leaving directory `/home/steven/gst-buzztard-0.6.0'
| make[1]: *** [all] Error 2
| make[1]: Leaving directory `/home/steven/gst-buzztard-0.6.0'
| make: *** [debian/stamp-makefile-build] Error 2

It links the testsuite binaries using the wrong libs.  There is a
CHECK_LIBS variable seemingly having the right ones but that isn't being
used currently.

The inline patch below fixes the build for me on kfreebsd-amd64:

--- gst-buzztard-0.6.0.orig/tests/Makefile.in   2011-12-15 08:27:51.000000000 +0000
+++ gst-buzztard-0.6.0/tests/Makefile.in        2014-03-30 15:50:24.446397154 +0100
@@ -280,7 +280,7 @@
 
 @BUILD_CHECK_TESTS_TRUE at gst_buzztard_LDADD = \
 @BUILD_CHECK_TESTS_TRUE@       $(top_builddir)/libgstbuzztard/libgstbuzztard.la \
- at BUILD_CHECK_TESTS_TRUE@       $(BASE_DEPS_LIBS) -lcheck
+ at BUILD_CHECK_TESTS_TRUE@       $(BASE_DEPS_LIBS) @CHECK_LIBS@
 
 @BUILD_CHECK_TESTS_TRUE at gst_buzztard_SOURCES = m-gst-buzztard.c m-gst-buzztard.h \
 @BUILD_CHECK_TESTS_TRUE@       s-gst-note2frequency.c e-gst-note2frequency.c t-gst-note2frequency.c

Thanks.

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: kfreebsd-amd64 (x86_64)

Kernel: kFreeBSD 9.0-2-amd64-xenhvm
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash