[Pkg-haproxy-maintainers] Bug#750459: Bug#750459: Bug#750459: Patch for haproy init script and link to the original launchpad bug report
apoikos at debian.org
Mon Jun 9 15:46:57 UTC 2014
On 23:44 Sun 08 Jun , Vincent Bernat wrote:
> ❦ 3 juin 2014 17:09 GMT, "Gabriel David (OI&T V)" <David.Gabriel at oeamtc.at> :
> > Ubuntu launchpad bug report
> > https://bugs.launchpad.net/ubuntu/+source/haproxy/+bug/1325847
> Testing the configuration is a good idea. However, there are several
> problems with the patch as is:
> 1. It uses bash. We try to only use sh. I could do the conversion if
> you are not comfortable with that. No big deal.
> 2. It is a lot more verbose. Most init scripts are as verbose as the
> original script. For example, when you uninstall haproxy, you don't
> expect to get a warning saying that haproxy executable is not here
> anymore. This is not an error. The init file being a configuration
> file, it usually stays here.
> 3. We need to have at least feature parity with the systemd
> unit. Notably, the support of conf.d directory is not possible
> directly with systemd. Test of the configuration should also be done
> with systemd. This is our default init system now.
Actually we do test the configuration in systemd, on reload. Testing on
startup is not necessary, since we keep the daemon in the foreground and
the startup failure will be noticed.
The conf.d directory can be supported indirectly, by using an
EnvironmentFile in systemd to specify a variable for the configuration.
A separate unit can then be used to dynamically generate the environment
file before haproxy is (re-)started. This unit need not be shipped by
us, it can be set up by the system administrator.
> As a side note, maybe it would be a time to remove the configuration
> knob to not enable haproxy at boot. It now features a working
> configuration out of the box and there is little interest to install
> haproxy and get it disabled by default.
Yes, I intended to do that in -dev25, but somehow it slipped through my
list of things.
More information about the Pkg-haproxy-maintainers