[Pkg-haproxy-maintainers] Bug#882610: Bug#882610: Please drop haproxy.service-start-after-syslog.patch

[Apollon Oikonomopoulos]

Control: severity -1 wishlist
Control: tags -1 wontfix

Hi Laurent,

On 19:22 Fri 24 Nov     , Laurent Bigonville wrote:
> Source: haproxy
> Version: 1.7.9-1
> Severity: normal
> 
> Hi,
> 
> I see in the haproxy.service file that you have a After=/Wants=syslog.service
> 
> The installed syslog implementation installed on the machine is always
> socket activated so adding After=/Wants=syslog.service is not needed
> (and can make the dependency chain more complex).
> 
> IMHO, the haproxy.service-start-after-syslog.patch patch should be
> dropped.
> 
> Do you have any specific reasons to keep this patch?

Unfortunately it's not that straightforward. HAProxy is running in a 
chroot under /var/lib/haproxy by default. To facilitate logging to 
syslog, we ship an rsyslog snippet that adds an additional syslog socket 
inside HAProxy's chroot. This socket does not take part in the socket 
activation mechanism, so we need an explicit dependency.

Now, we could probably discuss whether it makes sense to drop the chroot 
altogether in favor of something like ProtectSystem=full. But until 
then, I'm afraid the patch has to stay.

Regards,
Apollon