[pkg-horde] Bug#406728: imp4: "hide deleted messages" doesn't work

[Lionel Elie Mamane]

tags 406728 =upstream
forwarded 406728 http://bugs.horde.org/ticket/?id=4890
thanks

On Sat, Jan 13, 2007 at 01:51:41PM +0100, Yann Rouillard wrote:

> The "Hide deleted messages" preference doesn't seem to work when the
> trash folder usage is activated.

> Looking at the code, it seems the delhide works only if use_trash is
> disabled (!!)  Shouldn't it be the opposite behaviour ?

Hmm... No. Neither the current nor the opposite behaviour are good
IMHO. People that do not have "use trash" may still want to hide
deleted messages. But (unless overridden), the _default_ for "hide
deleted messages" should be on if use_trash is on and off if use_trash
is off. Or even _forced_ on if use_trash is on.

I would be tempted to make that something like:

            $this->_delhide = (($GLOBALS['prefs']->getValue('delhide') ||
                               !$GLOBALS['prefs']->getValue('use_trash')) &&
                               ($GLOBALS['imp_search']->isSearchMbox() ||
                               ($GLOBALS['prefs']->getValue('sortby') != SORTTHREAD)));

let's see what upstream thinks of it.

(And let's mention that using use_trash with IMAP boxes is asking for
 trouble in my opinion. It goes against the IMAP "way", that is just
 asking for bugs to crop up. I'd suggest my users to set use_vtrash if
 they want to see it that way visually. Muuuch cleaner.)

-- 
Lionel