[pkg-horde] Bug#504798: Bug#504798: Ingo: error in sieve 'equal' condition
Ola Lundqvist
opal at debian.org
Sat Nov 8 09:46:59 UTC 2008
Hi Miotto
Thanksa lot for the patch. What impact do this bug have? I mean what do
it cause? I'm trying to judge whether it should be put into lenny or not.
Best regards,
// Ola
On Fri, Nov 07, 2008 at 11:23:45AM +0100, Miotto Paolo wrote:
> Package: ingo1
> Severity: important
>
> I have found a bug in the translation of an "equal to" clause by the
> sieve backend: the clause is correctly stored in the database, but the
> Sieve script generated is always:
>
> if true {
>
> The cause is an incorrect string match for the "equal" condition: the
> string stored in the preferences is "equal" (and is correctly reported
> in the $_tests array, but is matched against a "equal to" string in
> the switch ($condition['match']) .
>
> I tested this patch and it worked for me:
>
> --- ./lib/Script/sieve.php.ORI 2006-10-31 08:24:34.000000000 +0000
> +++ ./lib/Script/sieve.php 2008-11-07 09:11:29.000000000 +0000
> @@ -488,7 +488,7 @@
> foreach ($filter['conditions'] as $condition) {
> $tmp = '';
> switch ($condition['match']) {
> - case 'equal to':
> + case 'equal':
> $tmp = &new
> Sieve_Test_Relational(array('comparison' => 'eq', 'headers' =>
> $condition['field'], 'value' => $condition['value']));
> $test->addTest($tmp);
> break;
>
> The bug is already present in the latest svn version of ingo.
>
> Regards.
>
> Paolo Miotto
>
>
> -------------------------------------------
> Paolo Miotto
> Centro Servizi Informatici e Telematici
> Università di Udine
> Via delle scienze, 208
> 33100 - UDINE
>
> Tel.: +39-0432-558909
> Fax.: +39-0432-558911
>
> e-mail: paolo.miotto at uniud.it
> -------------------------------------------
>
>
>
>
>
> ----------------------------------------------------------------------
> SEMEL (SErvizio di Messaging ELettronico) - CSIT -Universita' di Udine
>
>
>
>
>
> _______________________________________________
> pkg-horde-hackers mailing list
> pkg-horde-hackers at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-horde-hackers
>
--
--------------------- Ola Lundqvist ---------------------------
/ opal at debian.org Annebergsslingan 37 \
| ola at inguza.com 654 65 KARLSTAD |
| http://inguza.com/ +46 (0)70-332 1551 |
\ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 /
---------------------------------------------------------------
More information about the pkg-horde-hackers
mailing list