[pkg-horde] Bug#597603: horde3: temp-cleanup.cron returns failure if last "find" command exits with non-zero code

[Joel Smith]

Package: horde3
Version: 3.3.8+debian0-1
Severity: minor
Tags: patch

The script at /usr/share/horde3/scripts/temp-cleanup.cron runs
several find commands to find and remove any temporary files
created by Horde, but not removed.  Since it is potentially
running on a shared temporary directory, there is a distinct
possibilty that some directories there will not be readable
to the www-data user which runs the script from cron.  When
that happens, the find command will return a non-zero code,
and the script will exit with the non-zero code of the final
find command.  This results in a log message like this:

Sep 20 23:00:01 ns /USR/SBIN/CRON[26612]: (CRON) error (grandchild #26627 failed with exit status 1)

There is no reason for the temp-cleanup.cron script to
return anything other than success in these instances, so it
should be modified to exit with a 0 return code. (Like with
"exit 0" at the end.)

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/bash

Versions of packages horde3 depends on:
ii  apache2                  2.2.16-2        Apache HTTP Server metapackage
ii  apache2-mpm-prefork [htt 2.2.16-2        Apache HTTP Server - traditional n
ii  libapache2-mod-php5      5.2.12.dfsg.1-2 server-side, HTML-embedded scripti
ii  libjs-scriptaculous      1.8.3-1         JavaScript library for dynamic web
ii  lighttpd [httpd]         1.4.28-1        A fast webserver with minimal memo
ii  php-log                  1.12.0-1        log module for PEAR
ii  php-mail                 1.2.0-2         PHP PEAR module for sending email
ii  php-mail-mime            1.8.0-2         PHP PEAR module for creating MIME 
ii  php5-cgi                 5.2.12.dfsg.1-2 server-side, HTML-embedded scripti
ii  php5-gd                  5.2.12.dfsg.1-2 GD module for php5
ii  php5-mcrypt              5.2.12.dfsg.1-2 MCrypt module for php5

Versions of packages horde3 recommends:
pn  fckeditor                <none>          (no description available)
ii  locales                  2.11.2-5        Embedded GNU C Library: National L
ii  logrotate                3.7.8-6         Log rotation utility
ii  php-date                 1.4.7-1         PHP PEAR module for date and time 
ii  php-db                   1.7.13-2        PHP PEAR Database Abstraction Laye
pn  php-file                 <none>          (no description available)
pn  php-mdb2                 <none>          (no description available)
pn  php-mdb2-driver-mysql |  <none>          (no description available)
ii  php-services-weather     1.4.2-2         acts as an interface to various on
ii  php5-cli                 5.2.12.dfsg.1-2 command-line interpreter for the p
ii  php5-ldap                5.2.12.dfsg.1-2 LDAP module for php5
ii  php5-mysql               5.2.12.dfsg.1-2 MySQL module for php5
ii  tinymce                  3.3.8-1         platform independent web based Jav

Versions of packages horde3 suggests:
pn  chora2                <none>             (no description available)
ii  enscript              1.6.5.2-1          converts text to Postscript, HTML 
ii  gettext               0.18.1.1-2         GNU Internationalization utilities
pn  gollem                <none>             (no description available)
ii  imp4                  4.3.7+debian0-2    webmail component for horde framew
ii  kronolith2            2.3.4+debian0-1    calendar component for Horde Frame
ii  libgeoip1             1.4.7~beta6+dfsg-1 A non-DNS IP-to-country resolver l
pn  libwpd-tools          <none>             (no description available)
pn  mnemo2                <none>             (no description available)
pn  php-net-imap          <none>             (no description available)
pn  php5-auth-pam         <none>             (no description available)
ii  php5-mhash            5.2.12.dfsg.1-2    MHASH module for php5
pn  ppthtml               <none>             (no description available)
ii  rpm                   4.8.1-5            package manager for RPM
ii  source-highlight      3.1.4-1            convert source code to syntax high
ii  turba2                2.3.4+debian0-1    contact management component for h
pn  unrtf                 <none>             (no description available)
pn  webcpp                <none>             (no description available)
ii  wv                    1.2.4-2+b1         Programs for accessing Microsoft W
pn  xlhtml                <none>             (no description available)

-- Configuration Files:
/etc/horde/horde3/.htaccess [Errno 13] Permission denied: u'/etc/horde/horde3/.htaccess'
/etc/horde/horde3/conf.php [Errno 13] Permission denied: u'/etc/horde/horde3/conf.php'
/etc/horde/horde3/conf.xml [Errno 13] Permission denied: u'/etc/horde/horde3/conf.xml'
/etc/horde/horde3/hooks.php [Errno 13] Permission denied: u'/etc/horde/horde3/hooks.php'
/etc/horde/horde3/mime_drivers.php [Errno 13] Permission denied: u'/etc/horde/horde3/mime_drivers.php'
/etc/horde/horde3/motd.php [Errno 13] Permission denied: u'/etc/horde/horde3/motd.php'
/etc/horde/horde3/nls.php [Errno 13] Permission denied: u'/etc/horde/horde3/nls.php'
/etc/horde/horde3/prefs.php [Errno 13] Permission denied: u'/etc/horde/horde3/prefs.php'
/etc/horde/horde3/registry.d/README [Errno 13] Permission denied: u'/etc/horde/horde3/registry.d/README'
/etc/horde/horde3/registry.php [Errno 13] Permission denied: u'/etc/horde/horde3/registry.php'

-- no debconf information
-------------- next part --------------
--- /usr/share/horde3/scripts/temp-cleanup.cron.orig	2010-09-21 02:00:41.000000000 -0600
+++ /usr/share/horde3/scripts/temp-cleanup.cron	2010-09-21 02:01:45.000000000 -0600
@@ -41,3 +41,7 @@
 
 # Files from cancelled imports
 find $TMP_DIR -type f -name import\* -ctime +2 -exec rm -f {} \;
+
+# Always return true, so that when run from cron, find errors
+# won't trigger log messages
+exit 0