[Pkg-ia32-libs-maintainers] Processed: Re: Bug#531515: ia32-apt-get: breaks "dpkg --control" (>= 1.15.1) and debsums

[Axel Beckert]

Hi Goswin,

Goswin von Brederlow schrieb am Fri, Jun 12, 2009 at 09:20:32PM +0200:
> thank you for starcing the problem. Too me it looks like debsums calls
> dpkg-deb in an undocumented (although not uncommon for tools in
> general) way:

I don't think it's debsums. Debsums calls dpkg without "--", see line
491 of debsums:

    491         system 'dpkg', '--control', $deb, $control

But it doesn't call dpkg-deb, but dpkg (which is ok) and dpkg adds
this "--" since 1.15.1.

> 4: /usr/bin/dpkg-deb --control -- /var/cache/apt/archives/bzip2_1.0.5-2_amd64.deb /tmp/gD4mFRK2gm/DEBIAN
> 
> According to the manpage the syntax is:
> 
>         -e, --control archive [directory]
>
> There is no mention in the docs that dpkg-deb supports "--".

Then it's a bug that it's not documented anywhere else than in the
dpkg 1.15.1 changelog entry:

  * When dpkg delegates to dpkg-query or dpkg-deb to do the actual work, add
    the "--" marker to explicitely document the end of options so that
    arguments starting with a dash are not interpreted as options.
    Closes: #293163
    Thanks to Bill Allombert for the patch.

> Your patch isn't correct though, at least not complete. Think of this
> invocation:
> 
> dpkg-deb --control -- /var/cache/apt/archives/bzip2_1.0.5-2_amd64.deb

There you are right. Missed that one.

> In that case, despite having 3 arguments, the DIR has to default to
> $(pwd)/DEBIAN. I guess there is no way around fully scanning the
> arguments and counting the valid bits.

Looks so to me now, too. :-/

		Regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe at deuxchevaux.org  (Mail)
 X                                                | abe at noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)