[Pkg-ime-devel] Bug#478811: RFS: sunpinyin -- An input method engine for Simplified Chinese

[LI Daobing]

On Mon, Apr 5, 2010 at 01:34, kefu chai <tchaikov at gmail.com> wrote:
> Hi Daobing,
>
> Thanks a lot for your time!
>
> On Sun, Apr 4, 2010 at 11:15 AM, LI Daobing <lidaobing at debian.org> wrote:
>> Hello,
>>
>> On Sat, Mar 27, 2010 at 22:56, Kov Chai <tchaikov at gmail.com> wrote:
>>> Dear mentors,
>>>
>>> I am looking for a sponsor for my package "sunpinyin".
>>>
>>> * Package name    : sunpinyin
>>>  Version         : 2.0-3
>>>  Upstream Author : Lei Zhang <phill.zhang at sun.com> and others
>>> * URL             : http://sunpinyin.googlecode.com/
>>> * License         : LGPL/CDDL Dual license
>>>  Programming Lang: C++
>>>  Description     : an input method engine for Simplified Chinese.
>>>
>>> It builds these binary packages:
>>> ibus-sunpinyin - Sunpinyin input method of Chinese Language for IBus
>>> xsunpinyin - Standalone XIM server with Sunpinyin
>>> sunpinyin-data-be - Big-endian data file for SunPinyin input method engine
>>> sunpinyin-data-le - Little-endian data file for SunPinyin input method engine
>>>
>>>
>>> The package appears to be lintian clean.
>>>
>>> The upload would fix these bugs: 478811
>>>
>>> The package can be found on mentors.debian.net:
>>> - URL: http://mentors.debian.net/debian/pool/main/s/sunpinyin/
>>> - Source repository: deb-src http://mentors.debian.net/debian unstable main
>>>  contrib non-free
>>> - dget
>>>  http://mentors.debian.net/debian/pool/main/s/sunpinyin/sunpinyin_2.0-3.dsc
>>>
>>> I would be glad if someone uploaded this package for me.
>>>
>>> SunPinyin is an Chinese input method engine based on SLM (Statistical
>>> Language Model).
>>> .
>>> In addition to an IBus input module for Simplified Chinese, SunPinyin now
>>> also provides a XIM server with this IM engine which works much like fcitx.
>>> .
>>> SunPinyin is a Chinese input method engine features intelligent full-sentence
>>> input. It uses a mature SLM of back-off tri-gram language model. The upstream
>>> also provides a suite of utilities to train the SLM using raw corpus.
>>>
>>> Kind regards
>>>
>>
>> rejected
>>
>> 1. too many lintian warnings and erros
>> $ lintian sunpinyin_2.0-3_amd64.changes
>> W: sunpinyin source: missing-debian-source-format
>> W: ibus-sunpinyin: debian-changelog-file-is-a-symlink
>> E: xsunpinyin: malformed-override xsunpinyin-preferences: binary-without-manpage
>> W: xsunpinyin: debian-changelog-file-is-a-symlink
>> N: 2 tags overridden (2 warnings)
>>
>> 2. consider use debian 3.0 (quilt) format.
>>
>> 3. debian/copyright:
>> Files: raw/dict.utf8.tar.bz2
>> Copyright: 1997-2010, MDBG
>>           2010 Kov Chai <tchaikov at gmail.com>
>> License: CC-BY-SA-3.0
>>
>> please paste CC-BY-SA-3.0 license in debian/copyright
>>
>> 4. debian/copyright:
>> Files: debian/*
>> Copyright: 2007-2009, Kefu Chai <tchaikov at gmail.com>
>> License: GPL
>>
>> how about add a version to GPL (such as "GPL-3" or "GPL-3 or later")
>> and add following text:
>>
>>  On Debian systems, the complete text of GPL-? can be found in
>>  /usr/share/common-licenses/GPL-?
>>
>
>
> I just uploaded a revised package which addresses all your comments.
> Could you take a look at it at your convenience?
>
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/s/sunpinyin
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/s/sunpinyin/sunpinyin_2.0-4.dsc
>

rejected again:

the upstream[1] said SHA1 Checksum of sunpinyin-2.0.tar.gz:
29e2ea68de18cb98cd08a8680c75b8686a0aca85

but in your .dsc file:
Checksums-Sha1:
 67be5656db0782ea2e3eab136e46d78d9bd1310c 26316863 sunpinyin_2.0.orig.tar.gz

I think you should use the origin tarball instead of repack it.

[1] http://code.google.com/p/sunpinyin/downloads/detail?name=sunpinyin-2.0.tar.gz&can=2&q=

-- 
Best Regards
LI Daobing