[Pkg-ime-devel] Bug#635023: Bug#635023: ibus: Switch to dh_python2

[Osamu Aoki]

Hi,

I think it is good idea to fix these issues as soon as possible.  

But it looks like time to rewrite debian/rules using normal syntax of
using override_dh_foo... too when time allows.

On Thu, Jul 21, 2011 at 04:58:56PM -0400, Barry Warsaw wrote:
> Package: ibus
> Version: 1.3.9-2
> Severity: normal
> Tags: patch
> User: ubuntu-devel at lists.ubuntu.com
> Usertags: origin-ubuntu oneiric ubuntu-patch
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> python-support is officially deprecated:
> 
> http://article.gmane.org/gmane.linux.debian.devel.python/6948
> 
> In Ubuntu, we are removing python-support and python-central from our CDs.  As
> part of that work, I have converted ibus to use dh_python2 according to these
> guidelines:
> 
> http://wiki.debian.org/Python/TransitionToDHPython2
> 
> I hope you will accept this patch.  Thanks!
> 
> *** /tmp/tmpaNYTUP
> In Ubuntu, the attached patch was applied to achieve the following:
> 
> 
>   * Switch to dh_python2. (LP: 788514)
> 
> 
> Thanks for considering the patch.

I do not understand Li's intent on keeping
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=552293 reference in old
debbian/rules since Joey Hess does not think this as a bug in debhelper.

For me, debian/rules should be more like:
----
#!/usr/bin/make -f

dh $@ --with python2 --with autotools-dev

override_dh_auto_configure:
        dh_auto_configure -- --enable-static LDFLAGS="-Wl,--as-needed" --enable-gtk3

override_dh_auto_build:
        dh_auto_build
        cd po; make ibus.pot # https://bugs.launchpad.net/ubuntu/+source/ibus/+bug/188690

override_dh_auto_install:
	rm -rf $(CURDIR)/debian/tmp/usr/lib/libibus.la \
		$(CURDIR)/debian/tmp/usr/lib/gtk-2.0/2.10.0/immodules/im-ibus.a \
		$(CURDIR)/debian/tmp/usr/lib/gtk-2.0/2.10.0/immodules/im-ibus.la \
		$(CURDIR)/debian/tmp/usr/lib/gtk-3.0/3.0.0/immodules/im-ibus.a \
		$(CURDIR)/debian/tmp/usr/lib/gtk-3.0/3.0.0/immodules/im-ibus.la \
		$(CURDIR)/debian/tmp/etc/xdg \
		$(CURDIR)/debian/tmp/usr/share/applications/ibus.desktop
	dh_install --list-missing --fail-missing
	LD_LIBRARY_PATH=debian/libibus2/usr/lib:$(LD_LIBRARY_PATH) \
		dh_gtkmodules -p ibus-gtk -s \
		dh_gtkmodules -p ibus-gtk3 -s
----

This needs testing though...