[Pkg-ime-devel] Bug#722086: More suggested fixes from Ubuntu

[Osamu Aoki]

Hi Jeremy,

Thanks for patches.  
    0001-Simplify-dh_install-and-only-hide-ibus-setup-in-GNOM.patch
    0002-Restore-disable-silent-rules.patch

I agree these as very good clean ups.  Thanks.

    0003-Drop-ibus-xx-setup-frequent-lang.patch.patch

But this core change proposal, I disagree (at least now as first glance).

First of all, it looks like ***working*** here in GNOME 3.8 :-)

    I see "Show all input methods" at the bottom of list.
           ^^^^^^^^^^^^^^^^^^^^^^

> While GNOME and Unity users can use gnome-control-center for ibus
> preferences, I think users of other desktops may need to continue to
> use ibus-setup.

I agree.  Hiding parts, I had some resentment.  Your idea is good.

> I don't think ibus-xx-setup-frequent-lang.patch works since it's
> patching a gconf schema which isn't installed. 

That was my initial reaction to this in FC19.  But FC19 had nice hiding
and it is working here.

That is why I doubt your assessment of "patching a gconf schema".

Yes, the patch file contains a large patch to gconf schema XML in data.
But the patch file also contain 2 patches to python code in setup.

> If you depend on
> gsettings-desktop-schemas, perhaps you could use gsettings
> org.gnome.desktop.input-sources show-all-sources if you want to
> rewrite the patch.

So this patch may have some legacy unused portion for our build for XML
or this XML may be used to update gsettings-desktop-schemas, but at
least small code patch in it is the one it counts and it seems working
here.  Unless you tell me more or my test without this patch gives me
"Show all input methods" , I will keep this patch since it is in synch
with FC19.

I will check this later.

Osamu