[Pkg-ime-devel] Bug#748213: Function declaration without parameter type list shadows risk of stack underflow

[Michael Tautschnig]

Package: fcitx
Version: 1:4.2.8.3-3
Severity: wishlist
Usertags: goto-cc

During an analysis of all packages using our research compiler tool-chain (using
tools from the cbmc package) the following error was found:

The declaration of UnsetXErrorHandler in xerrorhandler.h

http://sources.debian.net/src/fcitx/1:4.2.8.3-3/src/module/x11/xerrorhandler.h?hl=27#L27

shadows the fact that UnsetXErrorHandler actually requires an argument:

http://sources.debian.net/src/fcitx/1:4.2.8.3-3/src/module/x11/xerrorhandler.c?hl=42#L42

As this argument, however, is unused the (single) call to UnsetXErrorHandler
might execute correctly at present. To avoid the risk of undefined behaviour,
the definition should be fixed (by removing the parameter).

Best,
Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ime-devel/attachments/20140515/87002f65/attachment.sig>