[Pkg-ime-devel] Comments regarding hime_0.9.10+git20150821+dfsg-1_amd64.changes

ChangZhuo Chen czchen at gmail.com
Fri Sep 25 14:26:56 UTC 2015


On Fri, Sep 25, 2015 at 07:11:55PM +0800, ChangZhuo Chen wrote:
> On Fri, Sep 25, 2015 at 03:14:07AM +0000, Scott Kitterman wrote:
> > Is there a reason you did not name libhime libhime-im-client1?  Based on the
> > provided library file and SO name, that's what I would have expected.
> 
> As far as I know, the libraries are used for HIME internally. They are
> not designed to be used outside. These libraries are separated only for
> multi-arch purpose.
> 
> I will confirm with upstream about this part.

Confirm with upstream that libhime-im-client1 is not designed to be used
outside HIME itself.

Please reject the package and I will provide a new one with the
following update:

*   Remove hime-dev
*   Update copyright information

> 
> > 
> > Also, while this is not severe enough for a reject on its own, I noticed that
> > there are instances of files where not all of the copyright holders are listed
> > in debian/copyright.  src/hime-setup-appearance.c is an example.  Among others
> > it has these whice are not in debian/copyright:
> > 
> >  * Copyright (C) 2012 tytsim <https://github.com/tytsim>
> >  * Copyright (C) 2012 Favonia <favonia at gmail.com>
> 
> Thank for the review, I will check the copyright for HIME.
> 
> > 
> > Scott K
> > 
> > 
> 
> -- 
> ChangZhuo Chen (陳昌倬) <czchen at debian.org>
> Debian Developer
> Key fingerprint = EC9F 905D 866D BE46 A896  C827 BE0C 9242 03F4 552D



-- 
ChangZhuo Chen (陳昌倬) <czchen at debian.org>
Debian Developer
Key fingerprint = EC9F 905D 866D BE46 A896  C827 BE0C 9242 03F4 552D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ime-devel/attachments/20150925/8b2297a1/attachment.sig>


More information about the Pkg-ime-devel mailing list