[Pkg-ime-devel] Bug#835913: ibus: please use dbus-run-session to set up dconf overrides
Simon McVittie
smcv at debian.org
Mon Aug 29 09:07:40 UTC 2016
Source: ibus
Version: 1.5.11-1
Severity: normal
Tags: upstream
User: dbus at packages.debian.org
Usertags: dbus-launch dbus-launch-for-infra
As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
I'm trying to reduce how much dbus-launch is used in Debian.
This package currently uses dbus-launch to run some infrastructure bits.
In this case it looks as though it would be simple to replace with
dbus-run-session. Pseudo-patch is something like this:
# data/dconf/Makefile.am
00-upstream-settings: $(srcdir)/make-dconf-override-db.sh | $(gsettings_SCHEMAS)
@$(MKDIR_P) db
- $(AM_V_GEN) $(srcdir)/make-dconf-override-db.sh > $@ || \
- { rc=$$?; $(RM) -rf $@; exit $$rc; }
+ $(AM_V_GEN) dbus-run-session -- $(srcdir)/make-dconf-override-db.sh > $@ || \
+ { rc=$$?; $(RM) -rf $@; exit $$rc; }
# data/dconf/make-dconf-override-db.sh
-eval `dbus-launch --sh-syntax`
-trap 'rm -rf $TMPDIR; kill $DBUS_SESSION_BUS_PID' ERR
+trap 'rm -rf $TMPDIR' ERR
...
-kill $DBUS_SESSION_BUS_PID
and a dependency on dbus (>= 1.8).
Alternatively, if upstream are for some reason still interested in
supporting obsolete versions of dbus, the script could use dbus-daemon
directly, similar to this Flatpak commit:
https://github.com/flatpak/flatpak/commit/6cc8062cfb3f9410d54a27e7ccca77c103e441e8
Thanks,
S
More information about the Pkg-ime-devel
mailing list