[Pkg-ime-devel] Bug#862814: ibus-ui (systray icon) mis-detects Qt/KDE version

[Osamu Aoki]

Hi,

On Sat, May 20, 2017 at 10:14:38AM +0900, Osamu Aoki wrote:
> Hi,
> 
> On Fri, May 19, 2017 at 10:06:20AM +0200, Ralf Jung wrote:
> > > On Wed, May 17, 2017 at 02:03:22PM +0200, Ralf Jung wrote:
> > >> (i.e., removing the preprocessor conditional entirely) fixes the
> > >> problem:  The icon is properly shown in the systray.
> ...
> > +++ ibus-1.5.14/ui/gtk3/panel.vala
> > @@ -1372,15 +1372,7 @@ class Panel : IBus.PanelService {
> >                  m_status_icon.set_from_file(icon_name);
> >              }
> >              else if (m_icon_type == IconType.INDICATOR) {
> > -#if INDICATOR_ENGINE_ICON
> >                  m_indicator.set_icon_full(icon_name, "");
> > -#else
> > -                warning("plasma-workspace 5.2 or later is required to " +
> > -                        "show the absolute path icon %s. Currently check " +
> > -                        "qtbase 5.4 since there is no way to check " +
> > -                        "the version of plasma-workspace.", icon_name);
> > -                m_indicator.set_icon_full("ibus-engine", "");
> > -#endif
> 
> 
> I see.  Then, this can be solved by defining INDICATOR_ENGINE_ICON.
> 
> Let's see what we have in Debian testing:
> 
> plasma-workspace
> 
> testing 4:5.8.6-2
> unstable 4:5.8.6-2
> Ubuntu 4:5.9.5.1-0ubuntu1
> 
> qtbase-opensource-src
> 
> ld-bpo:  5.3.2+dfsg-4+deb8u1~bpo70+1
> stable:  5.3.2+dfsg-4+deb8u2
> testing:  5.7.1+dfsg-3
> unstable:  5.7.1+dfsg-3
> exp: 5.9.0~beta.3+dfsg-1
> 
> OK, we have 
>  plasma-workspace      5.8   >> 5.2
>  qtbase-opensource-src 5.7.1 >> 5.4 
> 
> So we need to define INDICATOR_ENGINE_ICON.

As I looked in the configure.ac:

| # --enable-appindicator option.
| AC_ARG_ENABLE(appindicator,
|     AS_HELP_STRING([--enable-appindicator],
|                    [Build appindicator support]),
|     [enable_appindicator=$enableval],
|     [enable_appindicator=yes]
| )
| AM_CONDITIONAL([ENABLE_APPINDICATOR], [test x"$enable_appindicator" = x"yes"])
| ...
| enable_appindicator_engine_icon="no"
| if test x"$enable_appindicator" = x"yes"; then
|     enable_appindicator="yes (enabled, use --disable-appindicator to disable)"
| 
|     # Need qt5-qtbase-devel package
|     # There is no way to check the version of KStatusNotifierItem and
|     # check the version of qtbase here.
|     AC_MSG_CHECKING([for KDE5 appindicator engine icon])
|     PKG_CHECK_EXISTS([Qt5Gui >= 5.4],
|         enable_appindicator_engine_icon="yes"
|     )
|     AC_MSG_RESULT([$enable_appindicator_engine_icon])
| 
| fi
| if test x"$enable_appindicator_engine_icon" != x"yes" ; then
|     enable_appindicator_engine_icon="no (disabled, need qtbase-devel 5.4 or later)"
| fi
| AM_CONDITIONAL([ENABLE_APPINDICATOR_ENGINE_ICON],
|                [test x"$enable_appindicator_engine_icon" = x"yes"])
| 

Since CONFIGURE_FLAGS already has --enable-appindicator, I just need to
install qtbase5-dev.
 
$ debdiff ibus_1.5.14-2.dsc ibus_1.5.14-3.dsc 
dpkg-source: warning: extracting unsigned source package (/home/osamu/vcs-debian/ibus/ibus_1.5.14-3.dsc)
diff -Nru ibus-1.5.14/debian/changelog ibus-1.5.14/debian/changelog
--- ibus-1.5.14/debian/changelog	2016-12-10 15:26:04.000000000 +0900
+++ ibus-1.5.14/debian/changelog	2017-05-20 16:06:23.000000000 +0900
@@ -1,3 +1,10 @@
+ibus (1.5.14-3) unstable; urgency=medium
+
+  * Enable appindicator engine icon by the configure auto detection.
+    Closes: #862814
+
+ -- Osamu Aoki <osamu at debian.org>  Sat, 20 May 2017 16:06:23 +0900
+
 ibus (1.5.14-2) unstable; urgency=medium
 
   * Update d/control and d/watch file for URLs. 
diff -Nru ibus-1.5.14/debian/control ibus-1.5.14/debian/control
--- ibus-1.5.14/debian/control	2016-12-10 15:26:04.000000000 +0900
+++ ibus-1.5.14/debian/control	2017-05-20 15:18:43.000000000 +0900
@@ -32,6 +32,7 @@
                python-gi-dev,
                python3-all,
                python3-dbus,
+               qtbase5-dev,
                valac (>= 0.16)
 Standards-Version: 3.9.8
 Homepage: https://github.com/ibus/ibus/releases