[PKG-IRC-Maintainers] inspircd 2.0.16

[Guillaume Delacour]

Le mercredi 16 juillet 2014 à 14:39 +0200, Andreas Metzler a écrit :
> On 2014-07-16 Guillaume Delacour <gui at iroqwa.org> wrote:
> > Le mardi 15 juillet 2014 à 01:57 +0200, Guillaume Delacour a écrit :
> >> Le dimanche 13 juillet 2014 à 20:21 +0200, Andreas Metzler a écrit :
> [...]
> >>> ------------------
> >>> /etc/inspircd/inspircd.conf:
> >>> <pid file="/var/run/inspircd.pid">
> 
> >>> /lib/systemd/system/inspircd.service
> >>> PIDFile=/var/run/inspircd/inspircd.pid
> >>> ------------------
> [...]
> > File just renamed and new package uploaded to mentors (hint: correct
> > date of dsc file is 15-Jul-2014 21:32)
> [...]
> 
> Hello,
> 
> This still won't run on systemd since the daemon cannot generate
> /var/run/inspircd.pid if it is run unpriviledged (as user irc).

I wrongly tested with 2.0.5 on the wrong box (and focused only
on /var/run/inspircd/inspircd.pid) and it doesn't have problems with
systemd (as systemd run /etc/init.d/inspircd which launch the daemon
without --nofork).

Anyway, i agree with your proposal, have integrated it (all your
patches), tested on a systemd testing box even with reboot action and
have uploaded the (final ?) version of the package on mentors.

> 
> Possible fixes:
> #1 Change the pid file location. In the whole package, not just the
> service file.
> ametzler at argenau:inspircd-2.0.16$ grep -rl inspircd.pid debian/
> debian/inspircd.logrotate
> debian/inspircd.conf
> debian/inspircd.preinst
> debian/inspircd.service
> debian/inspircd.prerm
> debian/inspircd.init
> 
> #2 Change the code to allow to stop inspircd from trying to generate a
> pidfile (either aditional option or implied by nofork.
> 
> #3 (new idea)
> Duplicate how the init script works around the issue. In
> debian/inspircd.tmpfile generate a pidfile (instead of a pid
> directory).
> 
> The same problem exist for the logfile BTW.
> 
> Find attached a patch series implementing #3 this. (Works for
> me in a simple "does the daemon start and can I connect"-test.)
> 
> hth, cu Andreas

-- 
Guillaume Delacour <gui at iroqwa.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-irc-maintainers/attachments/20140717/aeb73b09/attachment.sig>