[Pkg-iscsi-maintainers] Bug#581200: iscsitarget-source applies kernel compatibility patches the wrong way

[Markus Schuster]

Hi Ritesh!

> > [..]
> 
> I have targeted this version for squeeze. For lenny, I have no plans and
>  would suggest you to stick with the version shipped in lenny. Patches are
>  welcome though.
> 
> > [..]
> 
> I am not sure what you mean here. Squeeze will ship with 2.6.32. KERN_VER
>  will detect it and will accordingly assign itself the value 2.6.32. If you
>  will be running squeeze with the supported kernel, iscsitarget will apply
>  the correct patch.

I think I missunderstood your intention in the debian/rules file. I thought 
your plan was to create a kernel version independent iscsitarget-source 
package. But this does not seem to be the case. 


> [..]
> BTW, how do you conclude that it needs all patches and not just
> compat-2.6.25-2.6.27.patch ?

Well, I've not really tried it, but if you have a look in the original 
Makefile you'll find a comment and some checks for kernel versions. And if you 
run it with a 2.6.26 kernel, it'll not only apply compat-2.6.25-2.6.27.patch, 
but all the newer patchsets first. Maybe you could "steal" from the original 
Makefile?

The Makefiles comment says:
# Please when adding patch sets start with the latest to the earliest
# the idea behind this is that by properly patching the latest code
# base first the earlier patch sets will not need to be modified.

Regards,
Markus