[Pkg-iscsi-maintainers] Bug#672122: open-iscsi: iscsi_auto kernel option don't work

[Ritesh Raj Sarraf]

Hello Emmanuel,

On Tuesday 08 May 2012 10:08 PM, JOORIS Emmanuel wrote:
> diff -crB open-iscsi-2.0.872/debian/extra/initramfs.hook open-iscsi-2.0.872-mod/debian/extra/initramfs.hook
> *** open-iscsi-2.0.872/debian/extra/initramfs.hook	2012-05-08 17:52:06.493705662 +0200
> --- open-iscsi-2.0.872-mod/debian/extra/initramfs.hook	2012-05-08 17:53:42.485704990 +0200
> ***************
> *** 26,31 ****
>   cp /etc/iscsi/initiatorname.iscsi $DESTDIR/etc
>   cp /etc/iscsi/iscsi.initramfs $DESTDIR/etc
>   
> ! for x in crc32c libcrc32c iscsi_tcp libiscsi scsi_transport_iscsi; do
>   	manual_add_modules ${x}
>   done
> --- 26,31 ----
>   cp /etc/iscsi/initiatorname.iscsi $DESTDIR/etc
>   cp /etc/iscsi/iscsi.initramfs $DESTDIR/etc
>   
> ! for x in crc32c libcrc32c iscsi_tcp libiscsi scsi_transport_iscsi iscsi_ibft; do
>   	manual_add_modules ${x}
>   done

This looks fine. Thanks.

> diff -crB open-iscsi-2.0.872/debian/extra/initramfs.local-top open-iscsi-2.0.872-mod/debian/extra/initramfs.local-top
> *** open-iscsi-2.0.872/debian/extra/initramfs.local-top	2012-05-08 17:52:06.489706341 +0200
> --- open-iscsi-2.0.872-mod/debian/extra/initramfs.local-top	2012-05-08 17:56:48.989722727 +0200
> ***************
> *** 27,32 ****
> --- 27,33 ----
>   	configure_networking
>   
>   	modprobe iscsi_tcp
> + 	modprobe iscsi_ibft
>   	modprobe crc32c
Perhaps this could go into the else section when ISCSI_AUTO is not used.

>   
>   	if [ -z $ISCSI_AUTO ]; then
> ***************
> *** 53,76 ****
>   	else
>   		iscsistart -b
>   	fi
> - 
> - 	if [ -z $ISCSI_TARGET_PORT ]; then
> - 		ISCSI_TARGET_PORT=3260
> - 	fi
> - 
> - 	if [ -z $ISCSI_TARGET_GROUP ]; then
> - 		ISCSI_TARGET_GROUP=1
> - 	fi
> - 
> - 	for i in $ISCSI_TARGET_IP; do
> - 	iscsistart -i $ISCSI_INITIATOR -t $ISCSI_TARGET_NAME	\
> - 		   -g $ISCSI_TARGET_GROUP -a $i \
> - 		   -p $ISCSI_TARGET_PORT \
> - 		   ${ISCSI_USERNAME:+-u "$ISCSI_USERNAME"}	\
> - 		   ${ISCSI_PASSWORD:+-w "$ISCSI_PASSWORD"}	\
> - 		   ${ISCSI_IN_USERNAME:+-U "$ISCSI_IN_USERNAME"}\
> - 		   ${ISCSI_IN_PASSWORD:+-W "$ISCSI_IN_PASSWORD"}
> - 	done
>   }
These are required in cases where you want multiple login sessions to
the target. The first if block only provides you with one session.

What I would be interested to know is how does it behave when you
provide multiple IPs and then use ISCSI_AUTO.

I can provide a custom build with the ibft kernel module load fix. Would
you be interested to test both the behaviors?
The current version in sid is: 2.0.872+git0.6676a1cf-2, which will
eventually land for Wheezy.

Please let me know. I can prepare a deb package for you.


-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-iscsi-maintainers/attachments/20120509/c50fe22f/attachment.pgp>